Bug 82149

Summary:

Split MediaList into internal and CSSOM types

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, kling, macpherson, menard, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

77745

Attachments:

Description	Flags
patch	none
rebased	webkit.review.bot: commit-queue-
Archive of layout-test-results from ec2-cr-linux-03	none
don't change spacing of cssText output	kling: review+

Antti Koivisto

Reported 2012-03-25 11:17:24 PDT

MediaList is a CSSOM type and should not be used internally.

Attachments
patch (53.49 KB, patch) 2012-03-25 11:32 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
rebased (54.64 KB, patch) 2012-03-25 15:23 PDT, Antti Koivisto	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ec2-cr-linux-03 (9.75 MB, application/zip) 2012-03-25 15:58 PDT, WebKit Review Bot	no flags	Details
don't change spacing of cssText output (54.61 KB, patch) 2012-03-25 16:19 PDT, Antti Koivisto	kling: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2012-03-25 11:32:48 PDT

Created attachment 133684 [details] patch

WebKit Review Bot

Comment 2 2012-03-25 11:36:09 PDT

Attachment 133684 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/css/MediaList.h:80: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 28 files If any of these errors are false positives, please file a bug against check-webkit-style.

Antti Koivisto

Comment 3 2012-03-25 15:23:30 PDT

Created attachment 133694 [details] rebased

WebKit Review Bot

Comment 4 2012-03-25 15:26:30 PDT

Attachment 133694 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/css/MediaList.h:80: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 28 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Review Bot

Comment 5 2012-03-25 15:58:43 PDT

Comment on attachment 133694 [details] rebased Attachment 133694 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12127555 New failing tests: fast/dom/css-dom-read-2.html fast/css/insertRule-media.html

WebKit Review Bot

Comment 6 2012-03-25 15:58:50 PDT

Created attachment 133697 [details] Archive of layout-test-results from ec2-cr-linux-03 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-03 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

Antti Koivisto

Comment 7 2012-03-25 16:19:10 PDT

Created attachment 133698 [details] don't change spacing of cssText output

WebKit Review Bot

Comment 8 2012-03-25 16:22:56 PDT

Attachment 133698 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/css/MediaList.h:80: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 28 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andreas Kling

Comment 9 2012-03-26 01:40:07 PDT

Comment on attachment 133698 [details] don't change spacing of cssText output View in context: https://bugs.webkit.org/attachment.cgi?id=133698&action=review r=me. > Source/WebCore/ChangeLog:115 > + Move the media query ownershit to CSSStyleSheet where it belongs. Accidental(?) typo: ownership. :)

Antti Koivisto

Comment 10 2012-03-26 04:52:56 PDT

trac.webkit.org/changeset/112076

Note You need to log in before you can comment on or make changes to this bug.