Summary: | Split MediaList into internal and CSSOM types | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||||||
Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | dglazkov, kling, macpherson, menard, webkit.review.bot | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 77745 | ||||||||||||
Attachments: |
|
Description
Antti Koivisto
2012-03-25 11:17:24 PDT
Created attachment 133684 [details]
patch
Attachment 133684 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/css/MediaList.h:80: More than one command on the same line [whitespace/newline] [4]
Total errors found: 1 in 28 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 133694 [details]
rebased
Attachment 133694 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/css/MediaList.h:80: More than one command on the same line [whitespace/newline] [4]
Total errors found: 1 in 28 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 133694 [details] rebased Attachment 133694 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12127555 New failing tests: fast/dom/css-dom-read-2.html fast/css/insertRule-media.html Created attachment 133697 [details]
Archive of layout-test-results from ec2-cr-linux-03
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Created attachment 133698 [details]
don't change spacing of cssText output
Attachment 133698 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/css/MediaList.h:80: More than one command on the same line [whitespace/newline] [4]
Total errors found: 1 in 28 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 133698 [details] don't change spacing of cssText output View in context: https://bugs.webkit.org/attachment.cgi?id=133698&action=review r=me. > Source/WebCore/ChangeLog:115 > + Move the media query ownershit to CSSStyleSheet where it belongs. Accidental(?) typo: ownership. :) trac.webkit.org/changeset/112076 |