Bug 82148

Summary: Remove duplicated GenerateConditionalString() from code generators
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, darin, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Kentaro Hara
Reported 2012-03-25 10:28:45 PDT
GenerateConditionalString()s are defined in each code generator, and they are doing the same thing. We should put GenerateConditionalString() in CodeGenerator.pm and remove duplicated code.
Attachments
Patch (30.86 KB, patch)
2012-03-25 10:30 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-03-25 10:30:49 PDT
Created attachment 133683 [details] Patch
WebKit Review Bot
Comment 2 2012-03-25 13:00:21 PDT
Comment on attachment 133683 [details] Patch Clearing flags on attachment: 133683 Committed r112036: <http://trac.webkit.org/changeset/112036>
WebKit Review Bot
Comment 3 2012-03-25 13:00:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.