Bug 82127

Summary:

Don't use CSSRuleList for child rule ownership

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, kling, macpherson, menard, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

77745

Attachments:

Description	Flags
patch	webkit.review.bot: commit-queue-
Archive of layout-test-results from ec2-cr-linux-04	none
security check CSSStyleSheet.rules too	none
more correct ChangeLog	kling: review+

Antti Koivisto

Reported 2012-03-24 07:22:58 PDT

CSSMediaRule, WebKitCSSKeyframesRule and WebKitRegionRule use CSSRuleList for storing children. They should use a simple rule vector instead. CSSRuleList is a CSSOM type that should be instantiated on demand for API purposes only.

Attachments
patch (45.64 KB, patch) 2012-03-24 08:34 PDT, Antti Koivisto	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ec2-cr-linux-04 (9.73 MB, application/zip) 2012-03-24 09:28 PDT, WebKit Review Bot	no flags	Details
security check CSSStyleSheet.rules too (46.63 KB, patch) 2012-03-24 10:48 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
more correct ChangeLog (46.66 KB, patch) 2012-03-24 11:10 PDT, Antti Koivisto	kling: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2012-03-24 08:34:28 PDT

Created attachment 133636 [details] patch

WebKit Review Bot

Comment 2 2012-03-24 08:37:50 PDT

Attachment 133636 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1 Source/WebCore/css/CSSRuleList.h:37: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Review Bot

Comment 3 2012-03-24 09:28:41 PDT

Comment on attachment 133636 [details] patch Attachment 133636 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12132098 New failing tests: http/tests/security/cannot-read-cssrules.html http/tests/security/cannot-read-cssrules-redirect.html

WebKit Review Bot

Comment 4 2012-03-24 09:28:49 PDT

Created attachment 133640 [details] Archive of layout-test-results from ec2-cr-linux-04 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-04 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

Antti Koivisto

Comment 5 2012-03-24 10:48:27 PDT

Created attachment 133641 [details] security check CSSStyleSheet.rules too

WebKit Review Bot

Comment 6 2012-03-24 10:52:32 PDT

Attachment 133641 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1 Source/WebCore/css/CSSRuleList.h:37: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.

Antti Koivisto

Comment 7 2012-03-24 11:10:25 PDT

Created attachment 133643 [details] more correct ChangeLog

WebKit Review Bot

Comment 8 2012-03-24 11:14:11 PDT

Attachment 133643 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1 Source/WebCore/css/CSSRuleList.h:37: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andreas Kling

Comment 9 2012-03-25 07:01:48 PDT

Comment on attachment 133643 [details] more correct ChangeLog View in context: https://bugs.webkit.org/attachment.cgi?id=133643&action=review r=me > Source/WebCore/css/CSSMediaRule.cpp:124 > + result.append(" "); Since we are touching this, we should also change " " to ' '. Same comment repeated for other applicable lines.

Antti Koivisto

Comment 10 2012-03-25 13:59:15 PDT

http://trac.webkit.org/changeset/112037

Antti Koivisto

Comment 11 2012-03-25 14:47:56 PDT

...and the test update in http://trac.webkit.org/changeset/112038

Note You need to log in before you can comment on or make changes to this bug.