Bug 82120

Summary:

Supersede t1504-c543-txt-decor-00-d-g.html with c543-txt-decor-000.html

Product:

WebKit

Reporter:

SravanKumar S(:sravan) <ssandela>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, joepeck, kbolisetty, mrahaman, pfeldman, simon.fraser, ssandela, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	pfeldman: review-
Patch	pfeldman: review-, webkit.review.bot: commit-queue-
Archive of layout-test-results from ec2-cr-linux-02	none
patch	none
Archive of layout-test-results from ec2-cr-linux-03	none
Archive of layout-test-results from ec2-cq-02	none

SravanKumar S(:sravan)

Reported 2012-03-24 01:06:58 PDT

Created attachment 133623 [details] Patch In follow up to Bug:61699. As webkit has got a policy to add a new bug for a new test. Brief Description: There are Multiple failures in css2.1/t1504-c543-txt-decor-00-d-g.html, this has been corrected in css test suite and text decorations got changed. Following are the links to confirm, http://lists.w3.org/Archives/Public/public-css-testsuite/2010Jan/0032.html http://test.csswg.org/suites/css2.1/20110323/html4/c543-txt-decor-000.htm So, just superseding t1504-c543-txt-decor-00-d-g.html with c543-txt-decor-000.html.

Attachments
Patch (110.36 KB, patch) 2012-03-24 01:06 PDT, SravanKumar S(:sravan)	pfeldman: review-	Details Formatted Diff Diff
Patch (103.54 KB, patch) 2012-03-26 00:38 PDT, SravanKumar S(:sravan)	pfeldman: review- webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ec2-cr-linux-02 (9.69 MB, application/zip) 2012-03-26 01:12 PDT, WebKit Review Bot	no flags	Details
patch (104.48 KB, patch) 2012-03-26 03:18 PDT, SravanKumar S(:sravan)	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ec2-cr-linux-03 (9.76 MB, application/zip) 2012-03-26 03:57 PDT, WebKit Review Bot	no flags	Details
Archive of layout-test-results from ec2-cq-02 (9.76 MB, application/zip) 2012-03-26 08:56 PDT, WebKit Review Bot	no flags	Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Pavel Feldman

Comment 1 2012-03-24 03:37:42 PDT

Comment on attachment 133623 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133623&action=review > LayoutTests/css2.1/20110323/c543-txt-decor-000.html:1 > +<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd"> I dont' see expectations for non-win platforms. > LayoutTests/platform/chromium/test_expectations.txt:1064 > +BUGWK61699 : css2.1/20110323/c543-txt-decor-000.html = IMAGE IMAGE+TEXT Please do not add it here - WebKit sheriff will do that for you.

SravanKumar S(:sravan)

Comment 2 2012-03-25 22:43:07 PDT

Thanks for the review, as i have only windows machine with me, i think you are asking me to add these entries in test_expectations.txt of individual ports. Will do that and will upload the patch again.

Pavel Feldman

Comment 3 2012-03-25 22:47:33 PDT

(In reply to comment #2) > Thanks for the review, as i have only windows machine with me, i think you are asking me to add these entries in test_expectations.txt of individual ports. > Will do that and will upload the patch again. No. You should not touch test_expectations. You should generate base expectations (applied to all ports) that will satisfy the main WebKit builders. Other port owners will generate baselines for their ports. My concern is that you are adding expectations to platform/win, while you should be adding them beside the test itself.

SravanKumar S(:sravan)

Comment 4 2012-03-26 00:38:58 PDT

Created attachment 133742 [details] Patch Patch, generated base expectations on MAC.

WebKit Review Bot

Comment 5 2012-03-26 01:12:48 PDT

Comment on attachment 133742 [details] Patch Attachment 133742 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12132652 New failing tests: css2.1/20110323/c543-txt-decor-000.html

WebKit Review Bot

Comment 6 2012-03-26 01:12:56 PDT

Created attachment 133745 [details] Archive of layout-test-results from ec2-cr-linux-02 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-02 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

Pavel Feldman

Comment 7 2012-03-26 01:40:11 PDT

Comment on attachment 133742 [details] Patch The last bullet "There should be a long blue underline between here and here" seems to be rendered poorly. Any idea on what is wrong? Is it test or implementation?

Pavel Feldman

Comment 8 2012-03-26 01:44:00 PDT

Comment on attachment 133742 [details] Patch As per comment #7 r-, we should not land tests with misleading expectations.

SravanKumar S(:sravan)

Comment 9 2012-03-26 03:18:18 PDT

Created attachment 133762 [details] patch Patch with correct test case.

WebKit Review Bot

Comment 10 2012-03-26 03:57:05 PDT

Comment on attachment 133762 [details] patch Attachment 133762 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12132720 New failing tests: css2.1/20110323/c543-txt-decor-000.html

WebKit Review Bot

Comment 11 2012-03-26 03:57:13 PDT

Created attachment 133768 [details] Archive of layout-test-results from ec2-cr-linux-03 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-03 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

WebKit Review Bot

Comment 12 2012-03-26 08:56:41 PDT

Comment on attachment 133762 [details] patch Rejecting attachment 133762 [details] from commit-queue. New failing tests: css2.1/20110323/c543-txt-decor-000.html Full output: http://queues.webkit.org/results/12132849

WebKit Review Bot

Comment 13 2012-03-26 08:56:49 PDT

Created attachment 133823 [details] Archive of layout-test-results from ec2-cq-02 The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: ec2-cq-02 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

Pavel Feldman

Comment 14 2012-03-26 09:43:47 PDT

Comment on attachment 133762 [details] patch Clearing flags on attachment: 133762 Committed r112112: <http://trac.webkit.org/changeset/112112>

Pavel Feldman

Comment 15 2012-03-26 09:46:09 PDT

All reviewed patches have been landed. Closing bug.

Julien Chaffraix

Comment 16 2012-03-26 10:36:25 PDT

*** Bug 61699 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.