Bug 82086

Summary: [chromium] RenderSurfaceChromium remove dead function declarations
Product: WebKit Reporter: Shawn Singh <shawnsingh>
Component: Layout and RenderingAssignee: Shawn Singh <shawnsingh>
Status: RESOLVED FIXED    
Severity: Normal CC: cc-bugs, jamesr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Shawn Singh
Reported 2012-03-23 13:54:40 PDT
grep comes up with no usage of RenderSurfaceChromium::prepareContentsTexture(), and there doesn't even seem to be an implementation. The same seems to be true for releaseContentsTexture() and draw(). Linux builds successfully without these declarations; a git blame shows these were added (with actual implementations) on different occasions, but now those implementations no longer exist? I think we can remove these 3 functions. Please feel free to WontFix this bug if they are actually needed!
Attachments
Patch (1.51 KB, patch)
2012-04-03 11:22 PDT, Shawn Singh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Shawn Singh
Comment 1 2012-04-03 11:22:36 PDT
Created attachment 135371 [details] Patch
Shawn Singh
Comment 2 2012-04-03 11:23:15 PDT
James, please feel free to WontFix it, or let me know if there is any other related cleanup that could be done.
James Robinson
Comment 3 2012-04-03 11:26:08 PDT
Comment on attachment 135371 [details] Patch Yarr, these be some dead functions. Walk the plank!
Shawn Singh
Comment 4 2012-04-03 11:27:00 PDT
Comment on attachment 135371 [details] Patch aye - thanks =)
WebKit Review Bot
Comment 5 2012-04-03 12:24:49 PDT
Comment on attachment 135371 [details] Patch Clearing flags on attachment: 135371 Committed r113070: <http://trac.webkit.org/changeset/113070>
WebKit Review Bot
Comment 6 2012-04-03 12:24:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.