Bug 82079

Summary: REGRESSION: editing/inserting/insert-bg-font.html fails on Lion
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, enrica, jberlin, mitz, webkit.review.bot
Priority: P1    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Ryosuke Niwa
Reported 2012-03-23 12:35:16 PDT
It seems like editing/inserting/insert-bg-font.html has been failing on Lion bots. http://build.webkit.org/results/Lion%20Intel%20Release%20(Tests)/r111885%20(6782)/results.html --- /Volumes/Data/slave/lion-intel-release-tests/build/layout-test-results/editing/inserting/insert-bg-font-expected.txt +++ /Volumes/Data/slave/lion-intel-release-tests/build/layout-test-results/editing/inserting/insert-bg-font-actual.txt @@ -1,5 +1,5 @@ - <div id="dv" contenteditable=""><span style="background-color: lightgrey">lightgrey background<font color="blue">blue font color over lightgrey background</font></span> + <div id="dv" contenteditable=""><span style="background-color: lightgrey">lightgrey&nbsp;background blue<font color="#0000ff">&nbsp;font color over lightgrey background</font></span> <div><span style="background-color: lightgrey"><font color="blue">this should also be blue over lightgrey</font></span></div></div> FYI, I can't reproduce this failure locally on my Snow Leopard machine.
Attachments
Patch (3.19 KB, patch)
2012-04-30 12:03 PDT, Koji Ishii 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2012-03-23 12:49:19 PDT
Oops, I menat Lion.
Ryosuke Niwa
Comment 2 2012-03-23 13:04:11 PDT
Added a failing expectation in http://trac.webkit.org/changeset/111891.
mitz
Comment 3 2012-03-23 14:23:16 PDT
Do you know when this started failing?
Ryosuke Niwa
Comment 4 2012-03-23 14:31:45 PDT
(In reply to comment #3) > Do you know when this started failing? Unfortunately not. It's weird that this failure only occurs on Lion.
mitz
Comment 5 2012-03-23 14:35:15 PDT
Lion is the first OS X release with autocorrect. Perhaps it’s kicking in during the test. I have not seen this failure earlier today when looking for “tests failing more than once on the Lion WebKit2 bots in a 40-50 revision range”, so I suspect it’s recent. Perhaps it’s a bot configuration issue involving autocorrect.
Ryosuke Niwa
Comment 6 2012-03-23 14:54:35 PDT
(In reply to comment #5) > Lion is the first OS X release with autocorrect. Perhaps it’s kicking in during the test. I have not seen this failure earlier today when looking for “tests failing more than once on the Lion WebKit2 bots in a 40-50 revision range”, so I suspect it’s recent. Perhaps it’s a bot configuration issue involving autocorrect. Possible but I'm still surprised that the element moved from one place to another. Maybe auto-correction code is changing the selection in some undesirable fashion?
Koji Ishii
Comment 7 2012-04-30 12:03:02 PDT
Created attachment 139500 [details] Patch
Ryosuke Niwa
Comment 8 2012-04-30 13:12:41 PDT
Thanks for the fix!
Koji Ishii
Comment 9 2012-04-30 18:04:05 PDT
Comment on attachment 139500 [details] Patch Thanks for the review!
WebKit Review Bot
Comment 10 2012-04-30 19:08:24 PDT
Comment on attachment 139500 [details] Patch Clearing flags on attachment: 139500 Committed r115700: <http://trac.webkit.org/changeset/115700>
WebKit Review Bot
Comment 11 2012-04-30 19:08:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.