Bug 82077

Summary: RexExp constructor last match properties should not rely on previous ovector
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fix
oliver: review+
Fix none

Gavin Barraclough
Reported 2012-03-23 12:22:36 PDT
This change simplifies matching, and will enable subpattern results to be fully lazily generated in the future.
Attachments
Fix (40.96 KB, patch)
2012-03-23 12:28 PDT, Gavin Barraclough 		oliver: review+
DetailsFormatted DiffDiff
Fix (44.21 KB, patch)
2012-03-23 12:44 PDT, Gavin Barraclough 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2012-03-23 12:28:57 PDT
Created attachment 133534 [details] Fix No overall performance impact (maybe 1% progression on v8-regexp, nothing significant overall).
Oliver Hunt
Comment 2 2012-03-23 12:37:51 PDT
Comment on attachment 133534 [details] Fix r=me, but you need to add the files to all the other project files.
Gavin Barraclough
Comment 3 2012-03-23 12:44:41 PDT
Created attachment 133538 [details] Fix
Gavin Barraclough
Comment 4 2012-03-23 12:57:50 PDT
Fixed in r111889
Note You need to log in before you can comment on or make changes to this bug.