Summary: | [chromium] Fix scrollbarLayerLostContext flaky test crash on 10.6 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adrienne Walker <enne> | ||||
Component: | New Bugs | Assignee: | Adrienne Walker <enne> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cc-bugs, enne, jamesr, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Adrienne Walker
2012-03-23 09:36:26 PDT
Created attachment 133503 [details]
Patch
Build error: http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.6%20%28dbg%29/builds/9074/steps/webkit_unit_tests/logs/stdio This happens maybe 10-20% of the time. Comment on attachment 133503 [details]
Patch
R=me
We should really just #ifdef the scrollbar stuff out on mac, calling in to cocoa is not threadsafe.
(In reply to comment #3) > (From update of attachment 133503 [details]) > R=me > > We should really just #ifdef the scrollbar stuff out on mac, calling in to cocoa is not threadsafe. I'll put up another patch to do that for platforms we don't support yet. I already saw a Windows "my scrollbars are black when I flip this flag" bug. Comment on attachment 133503 [details] Patch Clearing flags on attachment: 133503 Committed r111875: <http://trac.webkit.org/changeset/111875> All reviewed patches have been landed. Closing bug. |