Bug 82054

Summary: [chromium] Remove unused variables from unittest.
Product: WebKit Reporter: Jonathan Backer <backer>
Component: New BugsAssignee: Jonathan Backer <backer>
Status: RESOLVED FIXED    
Severity: Normal CC: danakj, enne, jamesr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Jonathan Backer
Reported 2012-03-23 07:18:14 PDT
[chromium] Remove unused variables from unittest.
Attachments
Patch (2.91 KB, patch)
2012-03-23 07:18 PDT, Jonathan Backer 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jonathan Backer
Comment 1 2012-03-23 07:18:52 PDT
Created attachment 133479 [details] Patch
Jonathan Backer
Comment 2 2012-03-23 07:22:18 PDT
Newer GCC is warning about the unused variable. CrOS builds with warnings as errors. So this is breaking building chrome for CrOS.
Dana Jansens
Comment 3 2012-03-23 07:23:25 PDT
Comment on attachment 133479 [details] Patch +1
Jonathan Backer
Comment 4 2012-03-23 07:25:46 PDT
jamesr@ or enne@, can I get an R+?
Adrienne Walker
Comment 5 2012-03-23 07:47:46 PDT
Comment on attachment 133479 [details] Patch We really need an ews bot that builds with this warning. :(
WebKit Review Bot
Comment 6 2012-03-23 07:54:18 PDT
Comment on attachment 133479 [details] Patch Clearing flags on attachment: 133479 Committed r111862: <http://trac.webkit.org/changeset/111862>
WebKit Review Bot
Comment 7 2012-03-23 07:54:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.