Summary: | [CSS Regions] CSS Regions enabled by default on Windows | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ion Rosca <rosca> | ||||||
Component: | CSS | Assignee: | Ion Rosca <rosca> | ||||||
Status: | RESOLVED DUPLICATE | ||||||||
Severity: | Normal | CC: | adele, donggwan.kim, hyatt, jberlin, mibalan, rosca, sfalken, shanestephens, WebkitBugTracker | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Windows 7 | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 57312 | ||||||||
Attachments: |
|
Description
Ion Rosca
2012-03-23 05:07:11 PDT
Created attachment 133466 [details]
First patch
Comment on attachment 133466 [details] First patch Attachment 133466 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12120643 Created attachment 133488 [details]
win fix
Comment on attachment 133488 [details]
win fix
This patch does not enable CSS Regions by default. It just adds WK1 API to enable CSS Regions. To enable it by default, you would have to add a line in Source/WebKit/win/WebPreferences.cpp that sets the default to true.
However, I am not sure that it is desirable to turn CSS Regions on by default on Windows.
(In reply to comment #4) > (From update of attachment 133488 [details]) > This patch does not enable CSS Regions by default. It just adds WK1 API to enable CSS Regions. To enable it by default, you would have to add a line in Source/WebKit/win/WebPreferences.cpp that sets the default to true. > > However, I am not sure that it is desirable to turn CSS Regions on by default on Windows. The default true worked for me beeing set in Source\WebKit2\Shared\WebPreferencesStore.h, which is not platform specific. Mac as well has no specific default value for CSS Regions. We could continue without adding default value in WebPreferences.cpp. Is it ok? Comment on attachment 133488 [details]
win fix
Seems reasonable. I agree with Jessie, it's not clear to me that CSS regions should be enabled by default on Win. That's really a decision for Apple.
|