Bug 8203

Summary:

REGRESSION: "Invite a friend" text field in GMail page spills out of table

Product:

WebKit

Reporter:

Adele Peterson <adele>

Component:

Forms

Assignee:

Beth Dakin <bdakin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, hyatt

Priority:

Keywords:

HasReduction, Regression

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
test case - reduction	none
m_minWidth should be 0 for percents	darin: review+

Description Adele Peterson 2006-04-05 17:12:18 PDT

"Invite a friend" text field in GMail page spills out of table

Reduction attached.

Comment 1 Adele Peterson 2006-04-05 17:13:12 PDT

Created attachment 7533 [details]
test case - reduction

Comment 2 Adele Peterson 2006-04-05 17:18:42 PDT

I think width:100% might not be doing what its supposed to do here.

Comment 3 Adele Peterson 2006-04-05 17:19:52 PDT

Note- the text field (in the reduction, and the live site) looks the right width in Firefox and in stock Safari.

Comment 4 Beth Dakin 2006-04-06 10:15:52 PDT

I think I have a fix for this...

Comment 5 Beth Dakin 2006-04-06 11:16:59 PDT

Created attachment 7540 [details]
m_minWidth should be 0 for percents

Here is the patch that fixes the test case. RenderReplaced::calcMinMaxWidth() sets m_minWidth to 0 when the width is a percent, so this patch copies that behavior into RenderTextField::calcMinMaxWidth(). This causes two layout tests to have different layout, but Hyatt thinks the new layout is more correct.

Comment 6 Darin Adler 2006-04-06 11:19:28 PDT

Comment on attachment 7540 [details]
m_minWidth should be 0 for percents

Sweet! Since Hyatt approves the concept, I definitely approve the patch. r=me

Comment 7 Beth Dakin 2006-04-06 11:43:08 PDT

I committed the fix.