Bug 8203

Summary: REGRESSION: "Invite a friend" text field in GMail page spills out of table
Product: WebKit Reporter: Adele Peterson <adele>
Component: FormsAssignee: Beth Dakin <bdakin>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, hyatt
Priority: P1 Keywords: HasReduction, Regression
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
test case - reduction
none
m_minWidth should be 0 for percents darin: review+

Adele Peterson
Reported 2006-04-05 17:12:18 PDT
"Invite a friend" text field in GMail page spills out of table Reduction attached.
Attachments
test case - reduction (192 bytes, text/html)
2006-04-05 17:13 PDT, Adele Peterson 		no flags
Details
m_minWidth should be 0 for percents (769 bytes, patch)
2006-04-06 11:16 PDT, Beth Dakin 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adele Peterson
Comment 1 2006-04-05 17:13:12 PDT
Created attachment 7533 [details] test case - reduction
Adele Peterson
Comment 2 2006-04-05 17:18:42 PDT
I think width:100% might not be doing what its supposed to do here.
Adele Peterson
Comment 3 2006-04-05 17:19:52 PDT
Note- the text field (in the reduction, and the live site) looks the right width in Firefox and in stock Safari.
Beth Dakin
Comment 4 2006-04-06 10:15:52 PDT
I think I have a fix for this...
Beth Dakin
Comment 5 2006-04-06 11:16:59 PDT
Created attachment 7540 [details] m_minWidth should be 0 for percents Here is the patch that fixes the test case. RenderReplaced::calcMinMaxWidth() sets m_minWidth to 0 when the width is a percent, so this patch copies that behavior into RenderTextField::calcMinMaxWidth(). This causes two layout tests to have different layout, but Hyatt thinks the new layout is more correct.
Darin Adler
Comment 6 2006-04-06 11:19:28 PDT
Comment on attachment 7540 [details] m_minWidth should be 0 for percents Sweet! Since Hyatt approves the concept, I definitely approve the patch. r=me
Beth Dakin
Comment 7 2006-04-06 11:43:08 PDT
I committed the fix.
Note You need to log in before you can comment on or make changes to this bug.