Bug 82003

Summary: [chromium] Disable failing unit test - CCLayerTreeHostImplTest.visibilityChangeResetsDamage
Product: WebKit Reporter: Michal Mocny <mmocny>
Component: New BugsAssignee: Michal Mocny <mmocny>
Status: RESOLVED FIXED    
Severity: Normal CC: enne, nduca
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch enne: review+, enne: commit-queue-

Description Michal Mocny 2012-03-22 19:19:21 PDT
[chromium] Fix failing unit test - CCLayerTreeHostImplTest.visibilityChangeResetsDamage
Comment 1 Michal Mocny 2012-03-22 19:19:58 PDT
Created attachment 133412 [details]
Patch
Comment 2 Michal Mocny 2012-03-22 19:21:19 PDT
Comment on attachment 133412 [details]
Patch

This test is no longer expected to pass as written.  Visibility change does not trigger backbuffer drop and should reset damage.
Comment 3 Michal Mocny 2012-03-22 19:23:48 PDT
Created attachment 133413 [details]
Patch
Comment 4 Adrienne Walker 2012-03-22 19:30:15 PDT
Comment on attachment 133413 [details]
Patch

Is this test even worth having anymore now that visibility doesn't affect damage? Can we just delete the test?
Comment 5 Michal Mocny 2012-03-22 19:34:17 PDT
Created attachment 133415 [details]
Patch
Comment 6 Adrienne Walker 2012-03-22 19:43:01 PDT
Comment on attachment 133415 [details]
Patch

I'll land this by hand to fix the bots.  Thanks.  :)
Comment 7 Michal Mocny 2012-03-22 19:43:42 PDT
No no, thank you!
Comment 8 Adrienne Walker 2012-03-22 19:50:04 PDT
Committed r111815: <http://trac.webkit.org/changeset/111815>