Bug 82003

Summary: [chromium] Disable failing unit test - CCLayerTreeHostImplTest.visibilityChangeResetsDamage
Product: WebKit Reporter: Michal Mocny <mmocny>
Component: New BugsAssignee: Michal Mocny <mmocny>
Status: RESOLVED FIXED    
Severity: Normal CC: enne, nduca
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch enne: review+, enne: commit-queue-

Michal Mocny
Reported 2012-03-22 19:19:21 PDT
[chromium] Fix failing unit test - CCLayerTreeHostImplTest.visibilityChangeResetsDamage
Attachments
Patch (1.70 KB, patch)
2012-03-22 19:19 PDT, Michal Mocny 		no flags
DetailsFormatted DiffDiff
Patch (1.70 KB, patch)
2012-03-22 19:23 PDT, Michal Mocny 		no flags
DetailsFormatted DiffDiff
Patch (3.68 KB, patch)
2012-03-22 19:34 PDT, Michal Mocny 		enne: review+
enne: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Michal Mocny
Comment 1 2012-03-22 19:19:58 PDT
Created attachment 133412 [details] Patch
Michal Mocny
Comment 2 2012-03-22 19:21:19 PDT
Comment on attachment 133412 [details] Patch This test is no longer expected to pass as written. Visibility change does not trigger backbuffer drop and should reset damage.
Michal Mocny
Comment 3 2012-03-22 19:23:48 PDT
Created attachment 133413 [details] Patch
Adrienne Walker
Comment 4 2012-03-22 19:30:15 PDT
Comment on attachment 133413 [details] Patch Is this test even worth having anymore now that visibility doesn't affect damage? Can we just delete the test?
Michal Mocny
Comment 5 2012-03-22 19:34:17 PDT
Created attachment 133415 [details] Patch
Adrienne Walker
Comment 6 2012-03-22 19:43:01 PDT
Comment on attachment 133415 [details] Patch I'll land this by hand to fix the bots. Thanks. :)
Michal Mocny
Comment 7 2012-03-22 19:43:42 PDT
No no, thank you!
Adrienne Walker
Comment 8 2012-03-22 19:50:04 PDT
Committed r111815: <http://trac.webkit.org/changeset/111815>
Note You need to log in before you can comment on or make changes to this bug.