Bug 81999

Summary: Tools/Scripts/build-jsc doesn't work after WTF move
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, fpizlo, gyuyoung.kim, jberlin, mrobinson, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 81844    
Bug Blocks:    
Attachments:
Description Flags
the patch eric: review+

Description Michael Saboff 2012-03-22 17:30:38 PDT 
build-jsc doesn't appear to build WTF after the WTF move and fails with linker errors.

If WTF is built with build-webkit, then build-jsc appears to work.
Comment 1 Eric Seidel (no email) 2012-03-22 17:37:58 PDT 
It's slightly confusing becasue some of the ports build each directory independently, and some don't.  It looks liek Qt is already setup to build WTF before buidling JSC in this script.  I recommend we just hack AppleMac/AppleWin to do similar to Qt for now.
Comment 2 Filip Pizlo 2012-03-22 17:39:55 PDT 
I believe I have a fix for this.
Comment 3 Filip Pizlo 2012-03-22 17:43:18 PDT 
Created attachment 133400 [details]
the patch
Comment 4 Eric Seidel (no email) 2012-03-22 17:45:21 PDT 
Comment on attachment 133400 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133400&action=review

This looks reasonable.

> Tools/Scripts/build-jsc:92
> +    chdir "../..";

chdrWebKit?
Comment 5 Filip Pizlo 2012-03-22 17:46:42 PDT 
(In reply to comment #4)
> (From update of attachment 133400 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=133400&action=review
> 
> This looks reasonable.
> 
> > Tools/Scripts/build-jsc:92
> > +    chdir "../..";
> 
> chdrWebKit?

Aha!  Didn't know about that, and it indeed works.  Will land with this change.
Comment 6 Andy Estes 2012-03-22 17:46:51 PDT 
Comment on attachment 133400 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133400&action=review

> Source/JavaScriptCore/bytecode/SamplingTool.h:127
> -        static void dump();
> +        JS_EXPORT_PRIVATE static void dump();

Did you mean to include this? It doesn't look relevant.
Comment 7 Filip Pizlo 2012-03-22 17:47:41 PDT 
(In reply to comment #6)
> (From update of attachment 133400 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=133400&action=review
> 
> > Source/JavaScriptCore/bytecode/SamplingTool.h:127
> > -        static void dump();
> > +        JS_EXPORT_PRIVATE static void dump();
> 
> Did you mean to include this? It doesn't look relevant.

Good catch, and no, it is not relevant.  Will revert.
Comment 8 Filip Pizlo 2012-03-22 17:51:38 PDT 
Landed in http://trac.webkit.org/changeset/111797