Bug 81983 – Move garden-o-matic progress feedback from non-modal dialogs to a status console anchored to the bottom of the page

• Component: New Bugs
• Status: RESOLVED FIXED

[Ojan Vafai]

Move garden-o-matic progress feedback from non-modal dialogs to a status console anchored to the bottom of the page

[Ojan Vafai]

Created attachment 133376 [details]
Patch

[Adam Barth]

Comment on attachment 133376 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133376&action=review

I assume this look pretty.  :)

> Tools/ChangeLog:10
> +        The dialogs get in the way if you are doing multiple rebaselines. Also,
> +        a number of people didn't realize that you could do multiple rebaselines
> +        in parallel. A non-modal dialog is just confusing.

I didn't realize you could do multiple rebaselines in parallel!

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:118
> +    // FIXME: Why don't we use Object.values(dictionary)?

Because I'm dumb and I didn't know that existed.

[Ojan Vafai]

(In reply to comment #2)
> (From update of attachment 133376 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=133376&action=review
> 
> I assume this look pretty.  :)

Not gonna win any beauty contests, but I think it's good enough. I'm happy to tweak it if you look at it and are disgusted. :)
 
> > Tools/ChangeLog:10
> > +        The dialogs get in the way if you are doing multiple rebaselines. Also,
> > +        a number of people didn't realize that you could do multiple rebaselines
> > +        in parallel. A non-modal dialog is just confusing.
> 
> I didn't realize you could do multiple rebaselines in parallel!

Lol. It works surprisingly well (albeit slowly).

> > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:118
> > +    // FIXME: Why don't we use Object.values(dictionary)?
> 
> Because I'm dumb and I didn't know that existed.

Lol. I'll fix this in a followup patch.

[Ojan Vafai]

Committed r111793: <http://trac.webkit.org/changeset/111793>