Bug 81982 – Password protect "Stop build" button

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Ryosuke Niwa]

It seems like the ability to stop a build is more harmful than the ability to force a build since builds are triggered automatically by commits quite often whereas canceling a build results in permanent data loss.

We should password-protect "stop build" button instead.

[Ryosuke Niwa]

Someone cancelled interrupted all builds again :( This is getting really disruptive. Can we just turn off
    stopBuild=True,
    stopAllBuilds=True,
    cancelPendingBuild=True,
?

[Ryosuke Niwa]

Created attachment 133451 [details]
Temporarily remove stop buttons

[Csaba Osztrogonác]

Comment on attachment 133451 [details]
Temporarily remove stop buttons

I think it is a too drastical change. I prefer 'auth' instead of False.

[Ryosuke Niwa]

(In reply to comment #3)
> (From update of attachment 133451 [details])
> I think it is a too drastical change. I prefer 'auth' instead of False.

Okay. Please feel free to post a patch since I'm not about to write a patch at 4:30am in the morning :)

[Csaba Osztrogonác]

Created attachment 139197 [details]
Patch

[Csaba Osztrogonác]

Today a crazy SPAM bot killed all builds on build.webkit.org again.
Some of them during svn update which cause new svn checkout ...

It's time to ban non committers from pressing stop buttons.

[Csaba Osztrogonác]

The web-page 'stop build' button was pressed by '<unknown>': hhxwdqvcmjdtpvsdf, <a href="http://www.jxeilrvoxv.com">qmhnjcetgh</a> , [url=http://www.iwctwfsdnh.com]zyzkhmqvws[/url], http://www.fffkhacygs.com qmhnjcetgh

Additionally we should add an IP ban for this user too.

[Csaba Osztrogonác]

One more force stop by a SPAM-mer today:
The web-page 'stop build' button was pressed by '<unknown>': <no reason specified>

ping for review ...

[Ryosuke Niwa]

Comment on attachment 139197 [details]
Patch

So I realize that form elements that have stop buttons in them don't have input elements for the authentication. we'll need to add them there.

[Csaba Osztrogonác]

(In reply to comment #9)
> (From update of attachment 139197 [details])
> So I realize that form elements that have stop buttons in them don't have input elements for the authentication. we'll need to add them there.

It isn't problem. There is input elements for authentication if the authentication is enabled. Check our master - http://build.webkit.sed.hu ,
you can find stop button. We didn't need any hack. ;)

[Ryosuke Niwa]

Comment on attachment 139197 [details]
Patch

Okay.

[Csaba Osztrogonác]

Comment on attachment 139197 [details]
Patch

CQ-, I'm going to land it when most of the bots are IDLE.

[Csaba Osztrogonác]

Comment on attachment 139197 [details]
Patch

Clearing flags on attachment: 139197

Committed r115957: <http://trac.webkit.org/changeset/115957>

[Csaba Osztrogonác]

All reviewed patches have been landed.  Closing bug.