Bug 8198

Summary: Hitting an assert on undo paste
Product: WebKit Reporter: Justin Garcia <justin.garcia>
Component: HTML EditingAssignee: Justin Garcia <justin.garcia>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
patch, changelog and layout tests darin: review+

Justin Garcia
Reported 2006-04-05 10:55:23 PDT
A combination of undoable and non-undoable removes are done from the ReplacementFragment.
Attachments
patch, changelog and layout tests (13.06 KB, patch)
2006-04-05 12:58 PDT, Justin Garcia 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Justin Garcia
Comment 1 2006-04-05 11:01:25 PDT
#0 0x02055ef4 in WebCore::RemoveNodeCommand::doUnapply at RemoveNodeCommand.cpp:57 #1 0x02044408 in WebCore::EditCommand::unapply at EditCommand.cpp:252 #2 0x0203a190 in WebCore::CompositeEditCommand::doUnapply at CompositeEditCommand.cpp:78 #3 0x02044408 in WebCore::EditCommand::unapply at EditCommand.cpp:252 #4 0x01ee9bb4 in -[WebCoreFrameBridge undoEditing:] at WebCoreFrameBridge.mm:1584
Justin Garcia
Comment 2 2006-04-05 12:58:19 PDT
Created attachment 7531 [details] patch, changelog and layout tests
Darin Adler
Comment 3 2006-04-05 14:09:37 PDT
Comment on attachment 7531 [details] patch, changelog and layout tests Typo in a couple places: "non-undable". Looks good, r=me. I'd like to see a clearer distinction between undoable and normal operations. Maybe we need to rename the undoable functions.
Note You need to log in before you can comment on or make changes to this bug.