Bug 81979

Summary: [Chromium] IndexedDB: Need test of Typed Arrays
Product: WebKit Reporter: Joshua Bell <jsbell>
Component: WebCore Misc.Assignee: Joshua Bell <jsbell>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, dgrogan, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Joshua Bell
Reported 2012-03-22 15:40:17 PDT
Typed Arrays are supported, but we don't have any tests that verify this to watch for regressions. Test should cover: * put/get of typed arrays (Uint8Array and friends) * use of arrays in stores with key paths (that involve extra SSV round-trips to Chromium's webkit utility process for key extraction)
Attachments
Patch (10.25 KB, patch)
2012-07-10 11:48 PDT, Joshua Bell 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joshua Bell
Comment 1 2012-07-10 11:48:58 PDT
Created attachment 151497 [details] Patch
Joshua Bell
Comment 2 2012-07-10 11:49:32 PDT
tony@ - r?
Alec Flett
Comment 3 2012-07-10 11:52:24 PDT
LGTM (never knew about the JS test systems is() function ... good to know)
Joshua Bell
Comment 4 2012-07-10 11:55:51 PDT
(In reply to comment #3) > LGTM > (never knew about the JS test systems is() function ... good to know) It's actually local to this test - I needed something that handled -0 and NaN properly. It should probably get pushed into the libraries at some point.
WebKit Review Bot
Comment 5 2012-07-10 14:21:51 PDT
Comment on attachment 151497 [details] Patch Clearing flags on attachment: 151497 Committed r122262: <http://trac.webkit.org/changeset/122262>
WebKit Review Bot
Comment 6 2012-07-10 14:21:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.