Bug 81961

Summary: OLD_COMPILE_FLAGS was set incorrectly in WebKitHelpers.cmake
Product: WebKit Reporter: Ming Xie <mxie>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: rakuco, rwlbuis, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Ming Xie 2012-03-22 14:06:22 PDT
This is a regression from trunk@109292

    IF (${TARGET_TYPE} STREQUAL "STATIC_LIBRARY") # -fPIC is automatically added to shared libraries
        SET(OLD_COMPILE_FLAGS "-fPIC")
    ENDIF ()

All the previous OLD_COMPILE_FLAGS are gone in this condition.
Comment 1 Ming Xie 2012-03-22 14:13:19 PDT
Created attachment 133340 [details]
Patch
Comment 2 Rob Buis 2012-03-22 14:17:32 PDT
Comment on attachment 133340 [details]
Patch

Looks good, not proper reference.
Comment 3 Ming Xie 2012-03-22 14:20:54 PDT
Created attachment 133344 [details]
Patch
Comment 4 Raphael Kubo da Costa (:rakuco) 2012-03-22 14:21:12 PDT
Sorry about that!
Comment 5 Rob Buis 2012-03-22 14:23:25 PDT
Comment on attachment 133344 [details]
Patch

Looks good.
Comment 6 WebKit Review Bot 2012-03-22 15:01:53 PDT
Comment on attachment 133344 [details]
Patch

Clearing flags on attachment: 133344

Committed r111769: <http://trac.webkit.org/changeset/111769>
Comment 7 WebKit Review Bot 2012-03-22 15:01:57 PDT
All reviewed patches have been landed.  Closing bug.