Bug 81960

Summary: Increase code sharing between StylePropertySet and CSSPropertyLonghand.
Product: WebKit Reporter: Alexis Menard (darktears) <menard>
Component: CSSAssignee: Alexis Menard (darktears) <menard>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, kling, koivisto, macpherson, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing
none
Patch for landing none

Description Alexis Menard (darktears) 2012-03-22 13:37:57 PDT
Increase code sharing between StylePropertySet and CSSPropertyLonghand.
Comment 1 Alexis Menard (darktears) 2012-03-22 13:42:33 PDT
Created attachment 133338 [details]
Patch
Comment 2 Alexis Menard (darktears) 2012-03-22 14:20:31 PDT
Created attachment 133343 [details]
Patch
Comment 3 Antti Koivisto 2012-03-22 14:59:46 PDT
nice, r=me
Comment 4 WebKit Review Bot 2012-03-22 15:28:24 PDT
Comment on attachment 133343 [details]
Patch

Attachment 133343 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12123184

New failing tests:
fast/dom/background-shorthand-csstext.html
fast/backgrounds/repeat/parsing-background-repeat.html
Comment 5 Alexis Menard (darktears) 2012-03-22 19:07:30 PDT
(In reply to comment #4)
> (From update of attachment 133343 [details])
> Attachment 133343 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/12123184
> 
> New failing tests:
> fast/dom/background-shorthand-csstext.html
> fast/backgrounds/repeat/parsing-background-repeat.html

Will look at the failures on monday.
Comment 6 Alexis Menard (darktears) 2012-03-26 04:28:00 PDT
Created attachment 133774 [details]
Patch for landing
Comment 7 Alexis Menard (darktears) 2012-03-26 04:33:28 PDT
Created attachment 133775 [details]
Patch for landing
Comment 8 WebKit Review Bot 2012-03-26 05:12:04 PDT
Comment on attachment 133775 [details]
Patch for landing

Clearing flags on attachment: 133775

Committed r112078: <http://trac.webkit.org/changeset/112078>
Comment 9 WebKit Review Bot 2012-03-26 05:12:14 PDT
All reviewed patches have been landed.  Closing bug.