Bug 81960

Summary: Increase code sharing between StylePropertySet and CSSPropertyLonghand.
Product: WebKit Reporter: Alexis Menard (darktears) <menard>
Component: CSSAssignee: Alexis Menard (darktears) <menard>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, kling, koivisto, macpherson, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing
none
Patch for landing none

Alexis Menard (darktears)
Reported 2012-03-22 13:37:57 PDT
Increase code sharing between StylePropertySet and CSSPropertyLonghand.
Attachments
Patch (24.94 KB, patch)
2012-03-22 13:42 PDT, Alexis Menard (darktears) 		no flags
DetailsFormatted DiffDiff
Patch (23.55 KB, patch)
2012-03-22 14:20 PDT, Alexis Menard (darktears) 		no flags
DetailsFormatted DiffDiff
Patch for landing (24.71 KB, patch)
2012-03-26 04:28 PDT, Alexis Menard (darktears) 		no flags
DetailsFormatted DiffDiff
Patch for landing (25.39 KB, patch)
2012-03-26 04:33 PDT, Alexis Menard (darktears) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Alexis Menard (darktears)
Comment 1 2012-03-22 13:42:33 PDT
Created attachment 133338 [details] Patch
Alexis Menard (darktears)
Comment 2 2012-03-22 14:20:31 PDT
Created attachment 133343 [details] Patch
Antti Koivisto
Comment 3 2012-03-22 14:59:46 PDT
nice, r=me
WebKit Review Bot
Comment 4 2012-03-22 15:28:24 PDT
Comment on attachment 133343 [details] Patch Attachment 133343 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12123184 New failing tests: fast/dom/background-shorthand-csstext.html fast/backgrounds/repeat/parsing-background-repeat.html
Alexis Menard (darktears)
Comment 5 2012-03-22 19:07:30 PDT
(In reply to comment #4) > (From update of attachment 133343 [details]) > Attachment 133343 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/12123184 > > New failing tests: > fast/dom/background-shorthand-csstext.html > fast/backgrounds/repeat/parsing-background-repeat.html Will look at the failures on monday.
Alexis Menard (darktears)
Comment 6 2012-03-26 04:28:00 PDT
Created attachment 133774 [details] Patch for landing
Alexis Menard (darktears)
Comment 7 2012-03-26 04:33:28 PDT
Created attachment 133775 [details] Patch for landing
WebKit Review Bot
Comment 8 2012-03-26 05:12:04 PDT
Comment on attachment 133775 [details] Patch for landing Clearing flags on attachment: 133775 Committed r112078: <http://trac.webkit.org/changeset/112078>
WebKit Review Bot
Comment 9 2012-03-26 05:12:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.