Bug 81951

Summary:

new-run-webkit-tests blames the wrong test for crashing

Product:

WebKit

Reporter:

Geoffrey Garen <ggaren>

Component:

Tools / Tests

Assignee:

Dirk Pranke <dpranke>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dpranke, eric, jberlin, ojan, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	abarth: review+

Geoffrey Garen

Reported 2012-03-22 12:56:13 PDT

See http://build.webkit.org/results/Lion%20Intel%20Release%20(WebKit2%20Tests)/r111739%20(5620)/results.html. It lists these tests as crashing in workers code: +css3/filters/custom/effect-custom-combined-missing.html +svg/custom/circular-clip-path-references-crash.svg +svg/custom/font-face-name-without-name-attr.svg +svg/custom/circular-marker-reference-1.svg +accessibility/contenteditable-hidden-div.html +fast/workers/empty-worker-nocrash.html +editing/style/relative-font-size-change-003.html Only one of these tests actually runs a worker.

Attachments
Patch (6.12 KB, patch) 2012-03-22 13:58 PDT, Dirk Pranke	abarth: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Dirk Pranke

Comment 1 2012-03-22 13:10:47 PDT

Okay, it looks like we're not picking up the pid of the WebProcess properly (which was added in r111619), so they're all probably picking up the most recent crash logs that they find at the time. Investigating further to see why we're not getting the pid ...

Dirk Pranke

Comment 2 2012-03-22 13:58:28 PDT

Created attachment 133339 [details] Patch

Dirk Pranke

Comment 3 2012-03-22 14:00:07 PDT

some day this code will all be right ... that'll be a nice day.

Dirk Pranke

Comment 4 2012-03-22 14:04:36 PDT

thanks for the review!

Dirk Pranke

Comment 5 2012-03-22 14:24:36 PDT

Committed r111765: <http://trac.webkit.org/changeset/111765>

Note You need to log in before you can comment on or make changes to this bug.