Bug 81933

Summary: [Qt][WK2] default families are not set in QWebPreferences
Product: WebKit Reporter: Pierre Rossi <pierre.rossi>
Component: New BugsAssignee: Pierre Rossi <pierre.rossi>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, kenneth, menard, rafael.lobo, vestbo, webkit.review.bot, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
kenneth: review+
Patch vestbo: review+, vestbo: commit-queue-

Description Pierre Rossi 2012-03-22 10:13:58 PDT 
[Qt][WK2] default families are not set in QWebPreferences
Comment 1 Pierre Rossi 2012-03-22 10:20:25 PDT 
Created attachment 133288 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2012-03-23 04:27:03 PDT 
Comment on attachment 133288 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133288&action=review

> Source/WebKit2/UIProcess/API/qt/qwebpreferences.cpp:101
> +void QWebPreferencesPrivate::initFontDefaults()

WebKit usually usees initialize and not init

> Source/WebKit2/UIProcess/API/qt/qwebpreferences.cpp:124
> +    setFontFamily(FixedFont, defaultFont.defaultFamily());
> +
> +}

unneeded newline!
Comment 3 Kenneth Rohde Christiansen 2012-03-23 04:27:30 PDT 
Comment on attachment 133288 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133288&action=review

>> Source/WebKit2/UIProcess/API/qt/qwebpreferences.cpp:101
>> +void QWebPreferencesPrivate::initFontDefaults()
> 
> WebKit usually usees initialize and not init

Also doesn DefaultFonts make more sense than FontDefaults?
Comment 4 Pierre Rossi 2012-03-26 10:05:05 PDT 
Committed r112116: <http://trac.webkit.org/changeset/112116>
Comment 5 Rafael Brandao 2012-03-26 11:11:03 PDT 
Reopening to attach new patch.
Comment 6 Rafael Brandao 2012-03-26 11:11:08 PDT 
Created attachment 133849 [details]
Patch

This patch has broken qt bots. This is the build fix, please land this ASAP.
Comment 7 Tor Arne Vestbø 2012-03-26 11:39:33 PDT 
Landed in r112132