Bug 81932

Summary: Web Inspector: text gutter decorations should move upon edits.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch vsevik: review+

Pavel Feldman
Reported 2012-03-22 10:04:22 PDT
Decorations set by the line number now shift as editing inserts / removes lines.
Attachments
Patch (4.69 KB, patch)
2012-03-22 10:06 PDT, Pavel Feldman 		vsevik: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2012-03-22 10:06:25 PDT
Created attachment 133285 [details] Patch
Vsevolod Vlasov
Comment 2 2012-03-22 12:09:31 PDT
Comment on attachment 133285 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133285&action=review > Source/WebCore/inspector/front-end/TextViewer.js:688 > + if (isNaN(lineNumber)) It's not an array. > Source/WebCore/inspector/front-end/TextViewer.js:701 > + // Do not move decorations after the end position. Do not restore
Pavel Feldman
Comment 3 2012-03-22 12:11:22 PDT
Committed r111743: <http://trac.webkit.org/changeset/111743>
Note You need to log in before you can comment on or make changes to this bug.