Bug 81932 - Web Inspector: text gutter decorations should move upon edits.
Summary: Web Inspector: text gutter decorations should move upon edits.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-22 10:04 PDT by Pavel Feldman
Modified: 2012-03-22 12:11 PDT (History)
10 users (show)

See Also:

Attachments
Patch (4.69 KB, patch)
2012-03-22 10:06 PDT, Pavel Feldman 		vsevik: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-03-22 10:04:22 PDT 
Decorations set by the line number now shift as editing inserts / removes lines.
Comment 1 Pavel Feldman 2012-03-22 10:06:25 PDT 
Created attachment 133285 [details]
Patch
Comment 2 Vsevolod Vlasov 2012-03-22 12:09:31 PDT 
Comment on attachment 133285 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133285&action=review

> Source/WebCore/inspector/front-end/TextViewer.js:688
> +                if (isNaN(lineNumber))

It's not an array.

> Source/WebCore/inspector/front-end/TextViewer.js:701
> +                    // Do not move decorations after the end position.

Do not restore
Comment 3 Pavel Feldman 2012-03-22 12:11:22 PDT 
Committed r111743: <http://trac.webkit.org/changeset/111743>