Bug 81929

Summary: [BlackBerry] DOMSupport isPositionInNode should have early returns for null nodes
Product: WebKit Reporter: Mike Fenton <mifenton>
Component: WebKit BlackBerryAssignee: Mike Fenton <mifenton>
Status: RESOLVED FIXED    
Severity: Normal CC: rwlbuis, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch with style suggestion made. none

Mike Fenton
Reported 2012-03-22 09:46:27 PDT
isPositionInNode should have early returns when the node, or the Position Node is null.
Attachments
Patch (2.12 KB, patch)
2012-03-22 09:55 PDT, Mike Fenton 		no flags
DetailsFormatted DiffDiff
Patch with style suggestion made. (2.18 KB, patch)
2012-03-22 11:47 PDT, Mike Fenton 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mike Fenton
Comment 1 2012-03-22 09:55:39 PDT
Created attachment 133283 [details] Patch
Rob Buis
Comment 2 2012-03-22 10:29:57 PDT
Comment on attachment 133283 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133283&action=review Looks good. > Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp:299 > int offset = 0; I would personally move this just before it is used, but no big deal.
WebKit Review Bot
Comment 3 2012-03-22 10:38:54 PDT
Comment on attachment 133283 [details] Patch Clearing flags on attachment: 133283 Committed r111726: <http://trac.webkit.org/changeset/111726>
WebKit Review Bot
Comment 4 2012-03-22 10:38:58 PDT
All reviewed patches have been landed. Closing bug.
Mike Fenton
Comment 5 2012-03-22 11:46:34 PDT
Re-open for style patch.
Mike Fenton
Comment 6 2012-03-22 11:47:02 PDT
Created attachment 133308 [details] Patch with style suggestion made.
Rob Buis
Comment 7 2012-03-22 11:48:10 PDT
Comment on attachment 133308 [details] Patch with style suggestion made. Thanks!
WebKit Review Bot
Comment 8 2012-03-22 13:58:32 PDT
Comment on attachment 133308 [details] Patch with style suggestion made. Clearing flags on attachment: 133308 Committed r111757: <http://trac.webkit.org/changeset/111757>
WebKit Review Bot
Comment 9 2012-03-22 13:58:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.