Summary: | [EFL] LayoutTestController needs implementation of goBack | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mikhail Pozdnyakov <mikhail.pozdnyakov> | ||||||||||
Component: | WebKit EFL | Assignee: | Chris Dumez <cdumez> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | cdumez, gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Linux | ||||||||||||
Attachments: |
|
Description
Mikhail Pozdnyakov
2012-03-22 08:22:11 PDT
Created attachment 133658 [details]
LayoutTestController goBack feature implementation.
Comment on attachment 133658 [details] LayoutTestController goBack feature implementation. View in context: https://bugs.webkit.org/attachment.cgi?id=133658&action=review > Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:609 > + DumpRenderTreeSupportEfl::goBack(browser->mainView()); ewk_frame_navigate()? Comment on attachment 133658 [details] LayoutTestController goBack feature implementation. View in context: https://bugs.webkit.org/attachment.cgi?id=133658&action=review > LayoutTests/ChangeLog:7 > + It looks you need to add simple description for this patch >> Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:609 >> + DumpRenderTreeSupportEfl::goBack(browser->mainView()); > > ewk_frame_navigate()? There are also ewk_frame_back(), ewk_frame_back_possible(). It seems to me that we don't need to add an function to DumpRenderTreeSupportEfl because ewk already supports APIs for backward | forward. Created attachment 133985 [details]
Improved patch based on review
The patch also bring implementation for setDefersLoading() so that the loader/navigation-while-deferring-loads.html test can be removed from skip-list.
Both changes look OK, but they seem unrelated to me. Can you explain your reasoning for not splitting these up into two patches? Created attachment 135073 [details]
Proposed patch
Split with #82890
Comment on attachment 135073 [details]
Proposed patch
Looks good to me.
Created attachment 135297 [details]
Proposed patch
Updated LayoutTests/ChangeLog based on philn-tp's feedback.
Comment on attachment 135297 [details] Proposed patch Clearing flags on attachment: 135297 Committed r113015: <http://trac.webkit.org/changeset/113015> All reviewed patches have been landed. Closing bug. |