Bug 81913 – Webkit build fails due to missing gstreamer include file on Kubuntu 8.04

• Component: Platform
• Status: RESOLVED FIXED

[Björn Toschi]

System is Kubuntu 8.04 shipping gstreamer 0.10.18. 
Ancient, I know :P

Building Webkit shipped with Qt 4.8.0 fails due missing include of <gst/interfaces/streamvolume.h> from "Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp".
As far as I can see, the affected Webkit version is from November 2011.

The missing include file does not exist in versions prior to gstreamer 0.10.27 (as far as I checked its gstreamer repositories),
and the configuration (taking place in Source/WebCore/features.pri in Qt's version)
only checks for existence of gstreamer-0.10 (development) package using pkg-config, not for its version.

There is a simple one-line patch (disabling HTML5 Video in that case):

diff Source/WebCore/features.pri.shipped Source/WebCore/features.pri
171c171
<         !contains(QT_CONFIG, no-pkg-config):system(pkg-config --exists glib-2.0 gio-2.0 gstreamer-0.10): {
---
>         !contains(QT_CONFIG, no-pkg-config):system(pkg-config --exists glib-2.0 gio-2.0 \'gstreamer-0.10 >= 0.10.27\'): {


Note that the .pri file was moved to Tools/make/mkspecs/features.prf with c99274, but as far as I can see even recent versions should be affected by this issue.

[Philippe Normand]

Would that be ok, Alexis?

[Alexis Menard (darktears)]

WTF.pri needs to be patched. You mind uploading a patch? Thanks.

[Philippe Normand]

Created attachment 138763 [details]
Patch

[Tor Arne Vestbø]

Hmm, the logic in WTF.pri is a bit busted here. It shouldn't replicate features.prf, but do something like:

linux-*:contains(DEFINES, WTF_USE_GSTREAMER=1) {
    DEFINES += ENABLE_GLIB_SUPPORT=1
    PKGCONFIG += glib-2.0 gio-2.0
}

(See similar logic in WebCore.pri)

and the patch you posted should be made to features.prf. Sorry for the confusion :/

[Philippe Normand]

Created attachment 138768 [details]
Patch

[Philippe Normand]

Created attachment 138770 [details]
Patch

[Tor Arne Vestbø]

Comment on attachment 138768 [details]
Patch

great! thanks!

[WebKit Review Bot]

Comment on attachment 138770 [details]
Patch

Clearing flags on attachment: 138770

Committed r115184: <http://trac.webkit.org/changeset/115184>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.