Bug 81910

Summary: [Qt][WK2] Pass Origin information to the DatabaseQuotaDialogContextObject
Product: WebKit Reporter: Alexander Færøy <ahf>
Component: WebKit QtAssignee: Alexander Færøy <ahf>
Status: RESOLVED FIXED    
Severity: Normal CC: menard, webkit.review.bot, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch hausmann: review+

Alexander Færøy
Reported 2012-03-22 07:53:22 PDT
[Qt][WK2] Pass Origin information to the DatabaseQuotaDialogContextObject
Attachments
Patch (13.36 KB, patch)
2012-03-22 07:58 PDT, Alexander Færøy 		no flags
DetailsFormatted DiffDiff
Patch (12.87 KB, patch)
2012-03-22 09:11 PDT, Alexander Færøy 		hausmann: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexander Færøy
Comment 1 2012-03-22 07:58:18 PDT
Created attachment 133264 [details] Patch
Alexander Færøy
Comment 2 2012-03-22 09:11:18 PDT
Created attachment 133274 [details] Patch
Simon Hausmann
Comment 3 2012-03-22 09:50:12 PDT
Comment on attachment 133274 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133274&action=review > Source/WebKit2/UIProcess/qt/QtDialogRunner.cpp:213 > + WKRetainPtr<WKStringRef> scheme = adoptWK(WKSecurityOriginCopyProtocol(securityOrigin)); > + WKRetainPtr<WKStringRef> host = adoptWK(WKSecurityOriginCopyHost(securityOrigin)); > + > + m_securityOrigin.setScheme(WKStringCopyQString(scheme.get())); > + m_securityOrigin.setHost(WKStringCopyQString(host.get())); > + m_securityOrigin.setPort(static_cast<int>(WKSecurityOriginGetPort(securityOrigin))); Would be nice to have a constructor for this in the future.
Alexander Færøy
Comment 4 2012-03-22 10:23:53 PDT
Committed r111721: <http://trac.webkit.org/changeset/111721>
Note You need to log in before you can comment on or make changes to this bug.