Bug 81910

Summary:

[Qt][WK2] Pass Origin information to the DatabaseQuotaDialogContextObject

Product:

WebKit

Reporter:

Alexander Færøy <ahf>

Component:

WebKit Qt

Assignee:

Alexander Færøy <ahf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

menard, webkit.review.bot, zoltan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	hausmann: review+

Description Alexander Færøy 2012-03-22 07:53:22 PDT

[Qt][WK2] Pass Origin information to the DatabaseQuotaDialogContextObject

Comment 1 Alexander Færøy 2012-03-22 07:58:18 PDT

Created attachment 133264 [details]
Patch

Comment 2 Alexander Færøy 2012-03-22 09:11:18 PDT

Created attachment 133274 [details]
Patch

Comment 3 Simon Hausmann 2012-03-22 09:50:12 PDT

Comment on attachment 133274 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133274&action=review

> Source/WebKit2/UIProcess/qt/QtDialogRunner.cpp:213
> +        WKRetainPtr<WKStringRef> scheme = adoptWK(WKSecurityOriginCopyProtocol(securityOrigin));
> +        WKRetainPtr<WKStringRef> host = adoptWK(WKSecurityOriginCopyHost(securityOrigin));
> +
> +        m_securityOrigin.setScheme(WKStringCopyQString(scheme.get()));
> +        m_securityOrigin.setHost(WKStringCopyQString(host.get()));
> +        m_securityOrigin.setPort(static_cast<int>(WKSecurityOriginGetPort(securityOrigin)));

Would be nice to have a constructor for this in the future.

Comment 4 Alexander Færøy 2012-03-22 10:23:53 PDT

Committed r111721: <http://trac.webkit.org/changeset/111721>