| Summary: | Merge SVGImageBufferTools to SVGRenderingContext | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Zoltan Herczeg <zherczeg> | ||||
| Component: | SVG | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Enhancement | CC: | krit, rakuco, webkit.review.bot, zimmermann | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Zoltan Herczeg
2012-03-22 04:17:42 PDT
Created attachment 133221 [details]
patch
Comment on attachment 133221 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=133221&action=review Looks great, r=me, in case cr-linux ews bot is also happy with it. > Source/WebCore/ChangeLog:11 > + no functionality change. > + You should note here, that this is the first step, towards making SVGImageBufferTools stageful, and this only moves the code. Thanks for the review. Landed as http://trac.webkit.org/changeset/111674 I'm not opposed to the change, but what is the reason for moving it? (In reply to comment #4) > I'm not opposed to the change, but what is the reason for moving it? Sorry for not including more context here, I discuss this since a while with Zoltan. The goal is to change the current state-less design of SVGImageBufferTools/SVGRenderingSupport. As first step Zoltan extracted the prepareRenderSVGContent/finishREnderSVGContent from SVGRenderSupport into SVGRenderingContext, making it state-full (not a bunch of static functions, but a real class holding data). This simplifies the SVG subtree rendering code a lot. SVGImageBufferTools suffers from the same problem. The intent is to merge it into SVGRenderingContext and make it state-full as well, removing the hacks currently needed for "currentContentTransformation" and fixing up the design in general. |