| Summary: | [BlackBerry] add interface clearCredentials() and clearNeverRememberSites() | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Dong <jonathan.dong.webkit> | ||||||
| Component: | WebKit BlackBerry | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | charles.wei, leo.yang, rwlbuis, tonikitoo, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Jonathan Dong
2012-03-22 03:19:40 PDT
Created attachment 133213 [details]
Patch
Comment on attachment 133213 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133213&action=review Looks good, but please fix typos and then let Charles or Leo cq+ or land for you. > Source/WebCore/ChangeLog:8 > + Fixed SQL issue when clear table logins and table never_remember. when clearing > Source/WebKit/blackberry/ChangeLog:12 > + Also implemented the corresponding funcions in class functions. > Source/WebKit/blackberry/ChangeLog:14 > + to perform the actuall clear table work. actual Created attachment 133239 [details]
Patch
Comment on attachment 133239 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133239&action=review Looks good. > Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp:418 > + HANDLE_SQL_EXEC_FAILURE(!m_database.executeCommand("DELETE FROM never_remember"), never_remember sounds like it can be improved upon, maybe an english native speaker has a suggestion, will ask in the office. Comment on attachment 133239 [details] Patch Clearing flags on attachment: 133239 Committed r111811: <http://trac.webkit.org/changeset/111811> All reviewed patches have been landed. Closing bug. |