Bug 81887

Summary: [BlackBerry] add interface clearCredentials() and clearNeverRememberSites()
Product: WebKit Reporter: Jonathan Dong <jonathan.dong.webkit>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: charles.wei, leo.yang, rwlbuis, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Jonathan Dong
Reported 2012-03-22 03:19:40 PDT
add interface function clearCredentials() and clearNeverRememberSites() into class WebPage, and implements its corresponding functions.
Attachments
Patch (6.35 KB, patch)
2012-03-22 03:33 PDT, Jonathan Dong 		no flags
DetailsFormatted DiffDiff
Patch (6.32 KB, patch)
2012-03-22 06:01 PDT, Jonathan Dong 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jonathan Dong
Comment 1 2012-03-22 03:33:01 PDT
Created attachment 133213 [details] Patch
Rob Buis
Comment 2 2012-03-22 04:25:09 PDT
Comment on attachment 133213 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133213&action=review Looks good, but please fix typos and then let Charles or Leo cq+ or land for you. > Source/WebCore/ChangeLog:8 > + Fixed SQL issue when clear table logins and table never_remember. when clearing > Source/WebKit/blackberry/ChangeLog:12 > + Also implemented the corresponding funcions in class functions. > Source/WebKit/blackberry/ChangeLog:14 > + to perform the actuall clear table work. actual
Jonathan Dong
Comment 3 2012-03-22 06:01:01 PDT
Created attachment 133239 [details] Patch
Rob Buis
Comment 4 2012-03-22 19:19:03 PDT
Comment on attachment 133239 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133239&action=review Looks good. > Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp:418 > + HANDLE_SQL_EXEC_FAILURE(!m_database.executeCommand("DELETE FROM never_remember"), never_remember sounds like it can be improved upon, maybe an english native speaker has a suggestion, will ask in the office.
WebKit Review Bot
Comment 5 2012-03-22 19:26:28 PDT
Comment on attachment 133239 [details] Patch Clearing flags on attachment: 133239 Committed r111811: <http://trac.webkit.org/changeset/111811>
WebKit Review Bot
Comment 6 2012-03-22 19:26:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.