Bug 81886
| Summary: | [Gtk] Compilation fails if RequestAnimationFrame feature is disabled after r110185 | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Zan Dobersek <zan> |
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | cgarcia, mrobinson |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Zan Dobersek
Compilation fails in ScrollAnimatorNone.h[1] if RequestAnimationFrame feature is disabled.
This started to occur after r110185[2].
A few ways of fixing this
- set ENABLE_SCROLL_ANIMATOR=1 in GNUmakefile.am only if RequestAnimationFrame feature is enabled
- refactor some of the WebCore code to always provide either a DisplayRefreshMonitor if provided or a fallback timer implementation.
[1] http://trac.webkit.org/browser/trunk/Source/WebCore/platform/ScrollAnimatorNone.h#L37
[2] http://trac.webkit.org/changeset/110185
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Zan Dobersek
The feature enabling is now rigid enough to not allow disabling the requestAnimationFrame feature support. Closing this as WONTFIX.