Bug 81877

Summary:

[Qt] Add full platforms to Qt buildslaves

Product:

WebKit

Reporter:

Csaba Osztrogonác <ossy>

Component:

Tools / Tests

Assignee:

Csaba Osztrogonác <ossy>

Status:

RESOLVED FIXED

Severity:

Critical

CC:

abarth, eric, jesus, lforschler, morrita, ossy, rniwa

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Csaba Osztrogonác

Reported 2012-03-22 00:25:46 PDT

It is necessary to make Qt WK2 perf bot happier. The problem is that the full platform is the uniqe key on the perf appspot to save the results from perf buildslaves. (I think the builder name would be better.) But unfortunately full platform is simple "qt" for all Qt buildslave. It isn't good, it should be fixed. This fix won't break anything else, because only perf test uses the full platform.

Attachments
Patch (5.77 KB, patch) 2012-03-22 00:32 PDT, Csaba Osztrogonác	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Csaba Osztrogonác

Comment 1 2012-03-22 00:32:01 PDT

Created attachment 133199 [details] Patch

Csaba Osztrogonác

Comment 2 2012-03-22 00:35:51 PDT

Comment on attachment 133199 [details] Patch cq-, I'd like to land it manually and watch the bots to ensure not break anything

Ryosuke Niwa

Comment 3 2012-03-22 00:36:47 PDT

Comment on attachment 133199 [details] Patch As long as it can build & run tests.

Csaba Osztrogonác

Comment 4 2012-03-22 00:51:18 PDT

Comment on attachment 133199 [details] Patch Clearing flags on attachment: 133199 Committed r111658: <http://trac.webkit.org/changeset/111658>

Csaba Osztrogonác

Comment 5 2012-03-22 00:51:26 PDT

All reviewed patches have been landed. Closing bug.

Csaba Osztrogonác

Comment 6 2012-03-22 01:02:07 PDT

Lucas, could you restart/reconfigure the master due to this change, please? It seems automatic reconfigure after master.cfg change doesn't work now. Have you got any idea why?

Lucas Forschler

Comment 7 2012-03-22 09:25:29 PDT

I've kicked off a reconfig. Please let me know if it is not as you expected.

Csaba Osztrogonác

Comment 8 2012-03-22 09:34:03 PDT

(In reply to comment #7) > I've kicked off a reconfig. Please let me know if it is not as you expected. It seems it didn't help. :( fullplatform on Qt slaves are still "qt" instead of the right fullplatform.

Csaba Osztrogonác

Comment 9 2012-03-22 09:51:39 PDT

Maybe a restart would help. It seems build.webkit.org is so sick now, there are 292 and 28 stucked build for SL builders, 197 stucked build for win builder.

Lucas Forschler

Comment 10 2012-03-22 09:56:28 PDT

just kicked off a restart. Hope that does the trick.

Csaba Osztrogonác

Comment 11 2012-03-22 09:58:09 PDT

Yes, now fullplatform is OK, many thanks.

Note You need to log in before you can comment on or make changes to this bug.