Summary: | [BlackBerry] Add HistoryItemViewState for BlackBerry port | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Leo Yang <leo.yang> | ||||||||||
Component: | WebKit BlackBerry | Assignee: | Leo Yang <leo.yang> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | charles.wei, rwlbuis, staikos, tonikitoo, webkit.review.bot, zimmermann | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 73144 | ||||||||||||
Attachments: |
|
Description
Leo Yang
2012-03-21 20:36:59 PDT
Created attachment 133179 [details]
Patch
Comment on attachment 133179 [details]
Patch
Looks good to me, this is blackberry-specific view state in the history. Need a webkit reviewer to approve this though.
Comment on attachment 133179 [details]
Patch
Let's remove const and mutable ...
Created attachment 133182 [details]
Patch v2
Comment on attachment 133182 [details] Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=133182&action=review LGTM. > Source/WebCore/ChangeLog:8 > + HistoryItemViewState is the balckberry specific field of HistoryItem. typo: balckberry Created attachment 133408 [details]
Patch for landing
Comment on attachment 133408 [details]
Patch for landing
Holding
Created attachment 133410 [details]
Patch for landing
Comment on attachment 133410 [details] Patch for landing Clearing flags on attachment: 133410 Committed r111819: <http://trac.webkit.org/changeset/111819> All reviewed patches have been landed. Closing bug. |