Bug 81867 - [BlackBerry] Add HistoryItemViewState for BlackBerry port
Summary: [BlackBerry] Add HistoryItemViewState for BlackBerry port
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Leo Yang
URL:
Keywords:
Depends on:
Blocks: 73144
  Show dependency treegraph
 
Reported: 2012-03-21 20:36 PDT by Leo Yang
Modified: 2012-03-22 20:21 PDT (History)
6 users (show)

See Also:


Attachments
Patch (2.73 KB, patch)
2012-03-21 20:41 PDT, Leo Yang
no flags Details | Formatted Diff | Diff
Patch v2 (2.71 KB, patch)
2012-03-21 21:22 PDT, Leo Yang
rwlbuis: review+
Details | Formatted Diff | Diff
Patch for landing (2.70 KB, patch)
2012-03-22 18:49 PDT, Leo Yang
leo.yang: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (2.70 KB, patch)
2012-03-22 18:56 PDT, Leo Yang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Leo Yang 2012-03-21 20:36:59 PDT
HistoryItemViewState is the balckberry specific field of HistoryItem.
Comment 1 Leo Yang 2012-03-21 20:41:29 PDT
Created attachment 133179 [details]
Patch
Comment 2 Charles Wei 2012-03-21 20:46:54 PDT
Comment on attachment 133179 [details]
Patch

Looks good to me,  this is blackberry-specific view state in the history.   Need a webkit reviewer to approve this though.
Comment 3 Leo Yang 2012-03-21 20:58:49 PDT
Comment on attachment 133179 [details]
Patch

Let's remove const and mutable ...
Comment 4 Leo Yang 2012-03-21 21:22:59 PDT
Created attachment 133182 [details]
Patch v2
Comment 5 Rob Buis 2012-03-22 04:32:09 PDT
Comment on attachment 133182 [details]
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=133182&action=review

LGTM.

> Source/WebCore/ChangeLog:8
> +        HistoryItemViewState is the balckberry specific field of HistoryItem.

typo: balckberry
Comment 6 Leo Yang 2012-03-22 18:49:29 PDT
Created attachment 133408 [details]
Patch for landing
Comment 7 Leo Yang 2012-03-22 18:53:35 PDT
Comment on attachment 133408 [details]
Patch for landing

Holding
Comment 8 Leo Yang 2012-03-22 18:56:13 PDT
Created attachment 133410 [details]
Patch for landing
Comment 9 WebKit Review Bot 2012-03-22 20:20:57 PDT
Comment on attachment 133410 [details]
Patch for landing

Clearing flags on attachment: 133410

Committed r111819: <http://trac.webkit.org/changeset/111819>
Comment 10 WebKit Review Bot 2012-03-22 20:21:02 PDT
All reviewed patches have been landed.  Closing bug.