Bug 81866

Summary: Expand RenderTextControlSingleLine::controlClipRect() to contain contentRect().
Product: WebKit Reporter: Kent Tamura <tkent>
Component: FormsAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: morrita, shinyak, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 80479    
Attachments:
Description Flags
Patch
none
Patch 2 none

Description Kent Tamura 2012-03-21 20:35:31 PDT 
Clip by contentRect() instead of container's frameRect() in RenderTextControlSingleLine
Comment 1 Kent Tamura 2012-03-21 22:20:55 PDT 
Created attachment 133189 [details]
Patch
Comment 2 Kent Tamura 2012-03-21 22:24:17 PDT 
Comment on attachment 133189 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133189&action=review

> Source/WebCore/ChangeLog:28
> +          â ShadowRoot
> +             â container element
> +        âââââââââââââââ<input> box
> +        â ââââââââââââ â
> +        â âcontainer box       â â
> +        â ââââââââââââ â
> +        âââââââââââââââ

Broken by Bug 75394.  Please look at https://bugs.webkit.org/attachment.cgi?id=133189 instead.
Comment 3 Hajime Morrita 2012-03-21 23:52:13 PDT 
Comment on attachment 133189 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133189&action=review

Do we really need to handle searchbox specially?
can be just compute union of content element and clip?

> Source/WebCore/rendering/RenderTextControlSingleLine.cpp:375
> +        RenderBox* containerBox = containerElement()->renderBox();

It looks we can expect containerbox being not null according to the original code?
Comment 4 Kent Tamura 2012-03-21 23:56:00 PDT 
(In reply to comment #3)
> Do we really need to handle searchbox specially?
> can be just compute union of content element and clip?

Oh, union is a good idea.
Comment 5 Kent Tamura 2012-03-22 00:13:57 PDT 
Created attachment 133197 [details]
Patch 2
Comment 6 WebKit Review Bot 2012-03-22 01:06:54 PDT 
Comment on attachment 133197 [details]
Patch 2

Clearing flags on attachment: 133197

Committed r111660: <http://trac.webkit.org/changeset/111660>
Comment 7 WebKit Review Bot 2012-03-22 01:06:58 PDT 
All reviewed patches have been landed.  Closing bug.