Summary: | [Chromium] Should check m_socket in SocketStreamHandleInternal::close() | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kenichi Ishibashi <bashi> | ||||||
Component: | WebCore Misc. | Assignee: | Kenichi Ishibashi <bashi> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | tkent, toyoshim, webkit.review.bot, yutak | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Kenichi Ishibashi
2012-03-21 18:21:44 PDT
Created attachment 133161 [details]
Patch
(In reply to comment #1) > Created an attachment (id=133161) [details] > Patch This patch doesn't include test because user interaction (closing alert popup) is needed to reproduce the problem. (In reply to comment #2) > (In reply to comment #1) > > Created an attachment (id=133161) [details] [details] > > Patch > > This patch doesn't include test because user interaction (closing alert popup) is needed to reproduce the problem. Would you add reasons why m_socket can be 0 and why alert() affects to ChangeLog? Created attachment 133192 [details]
Patch
> Would you add reasons why m_socket can be 0 and why alert() affects to ChangeLog?
Thank you for review. Added explanations to ChangeLog.
Comment on attachment 133192 [details]
Patch
ok
Comment on attachment 133192 [details] Patch Clearing flags on attachment: 133192 Committed r111656: <http://trac.webkit.org/changeset/111656> All reviewed patches have been landed. Closing bug. |