Bug 81840

Summary: DFG speculation on booleans should be rationalized
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch barraclough: review+

Filip Pizlo
Reported 2012-03-21 15:52:35 PDT
Right now there is a bit of a mess of calls to isKnownBoolean() for some code paths and shouldSpeculateBoolean() for others. From the standpoint of trying to reason about the types of nodes, we should stick to using shouldSpeculateBoolean() as the main guard, which secondary guards based on AbstractState to determine if the boolean checks have already been performed.
Attachments
the patch (13.61 KB, patch)
2012-03-21 16:32 PDT, Filip Pizlo 		barraclough: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2012-03-21 16:32:30 PDT
Created attachment 133141 [details] the patch
Filip Pizlo
Comment 2 2012-03-21 20:48:18 PDT
Landed in http://trac.webkit.org/changeset/111649
Note You need to log in before you can comment on or make changes to this bug.