Bug 81822

Summary: [MutationObservers] attributeFilter should be case sensitive at all times
Product: WebKit Reporter: Rafael Weinstein <rafaelw>
Component: DOMAssignee: Rafael Weinstein <rafaelw>
Status: RESOLVED FIXED    
Severity: Normal CC: adamk, ojan, rniwa, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 68729    
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Rafael Weinstein 2012-03-21 12:14:51 PDT
The current behavior is that it is case insensitive for HTML elements in an HTML document. This should be removed as it is inconsistent with the spec.
Comment 1 Rafael Weinstein 2012-03-21 12:18:32 PDT
Created attachment 133092 [details]
Patch
Comment 2 Adam Klein 2012-03-21 12:23:47 PDT
Comment on attachment 133092 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133092&action=review

thanks

> Source/WebCore/dom/MutationObserverRegistration.cpp:117
> +    return (m_attributeFilter.contains(attributeName));

Nit: no need for parens here.
Comment 3 Ojan Vafai 2012-03-21 12:26:26 PDT
Comment on attachment 133092 [details]
Patch

Was this discussed on a mailing list? Can you point to the relevant part of the spec?
Comment 4 Ojan Vafai 2012-03-21 12:34:31 PDT
Comment on attachment 133092 [details]
Patch

Discussed this in person with Rafael. The discussion happened on #whatwg. The summary sounds like the following to me:
-Attribute names in HTML are actually all lowercase.
-Legacy APIs like setAttribute, querySelector and the HTML Parser lowercase attribute names for you.
-New APIs should just only accept lowercase attributes.

I don't buy that argument and will bring this up again on whatwg@.
Comment 5 Ryosuke Niwa 2012-03-21 12:34:33 PDT
Comment on attachment 133092 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133092&action=review

>> Source/WebCore/dom/MutationObserverRegistration.cpp:117
>> +    return (m_attributeFilter.contains(attributeName));
> 
> Nit: no need for parens here.

Yup, please fix this nit before landing it.
Comment 6 Rafael Weinstein 2012-03-23 13:47:33 PDT
Created attachment 133550 [details]
Patch for landing
Comment 7 WebKit Review Bot 2012-03-23 15:09:07 PDT
Comment on attachment 133550 [details]
Patch for landing

Rejecting attachment 133550 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 11102 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
47>At revision 11102.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/12116869
Comment 8 WebKit Review Bot 2012-03-23 17:58:24 PDT
Comment on attachment 133550 [details]
Patch for landing

Clearing flags on attachment: 133550

Committed r111950: <http://trac.webkit.org/changeset/111950>
Comment 9 WebKit Review Bot 2012-03-23 17:58:29 PDT
All reviewed patches have been landed.  Closing bug.