Bug 81822 – [MutationObservers] attributeFilter should be case sensitive at all times

• Component: DOM
• Status: RESOLVED FIXED

[Rafael Weinstein]

The current behavior is that it is case insensitive for HTML elements in an HTML document. This should be removed as it is inconsistent with the spec.

[Rafael Weinstein]

Created attachment 133092 [details]
Patch

[Adam Klein]

Comment on attachment 133092 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133092&action=review

thanks

> Source/WebCore/dom/MutationObserverRegistration.cpp:117
> +    return (m_attributeFilter.contains(attributeName));

Nit: no need for parens here.

[Ojan Vafai]

Comment on attachment 133092 [details]
Patch

Was this discussed on a mailing list? Can you point to the relevant part of the spec?

[Ojan Vafai]

Comment on attachment 133092 [details]
Patch

Discussed this in person with Rafael. The discussion happened on #whatwg. The summary sounds like the following to me:
-Attribute names in HTML are actually all lowercase.
-Legacy APIs like setAttribute, querySelector and the HTML Parser lowercase attribute names for you.
-New APIs should just only accept lowercase attributes.

I don't buy that argument and will bring this up again on whatwg@.

[Ryosuke Niwa]

Comment on attachment 133092 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133092&action=review

>> Source/WebCore/dom/MutationObserverRegistration.cpp:117
>> +    return (m_attributeFilter.contains(attributeName));
> 
> Nit: no need for parens here.

Yup, please fix this nit before landing it.

[Rafael Weinstein]

Created attachment 133550 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 133550 [details]
Patch for landing

Rejecting attachment 133550 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 11102 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
47>At revision 11102.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/12116869

[WebKit Review Bot]

Comment on attachment 133550 [details]
Patch for landing

Clearing flags on attachment: 133550

Committed r111950: <http://trac.webkit.org/changeset/111950>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.