Bug 81821

Summary:

TileCache needs to know if its containing page is in a window

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	kling: review+

Description Anders Carlsson 2012-03-21 12:09:56 PDT

TileCache needs to know if its containing page is in a window

Comment 1 Anders Carlsson 2012-03-21 12:11:23 PDT

Created attachment 133090 [details]
Patch

Comment 2 Andreas Kling 2012-03-21 12:19:24 PDT

Comment on attachment 133090 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133090&action=review

r=me buuut..

> Source/WebCore/page/FrameView.cpp:855
> +        tiledBacking->setIsInWindow(true);

Should be setIsInWindow(false).

> Source/WebCore/page/Page.h:423
> +        bool m_isOnscreen;

My gut says s/m_isOnscreen/m_isOnScreen/g. But my gut has been wrong before.

> Source/WebCore/platform/graphics/ca/mac/TileCache.mm:227
> +    if (m_isInWindow == isInWindow)
> +        return;

I assume there's more code coming to this function, otherwise this is pretty overkill.

Comment 3 Anders Carlsson 2012-03-21 12:24:57 PDT

Committed r111593: <http://trac.webkit.org/changeset/111593>