Bug 81821 - TileCache needs to know if its containing page is in a window
Summary: TileCache needs to know if its containing page is in a window
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-21 12:09 PDT by Anders Carlsson
Modified: 2012-03-21 12:24 PDT (History)
0 users

See Also:


Attachments
Patch (7.85 KB, patch)
2012-03-21 12:11 PDT, Anders Carlsson
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2012-03-21 12:09:56 PDT
TileCache needs to know if its containing page is in a window
Comment 1 Anders Carlsson 2012-03-21 12:11:23 PDT
Created attachment 133090 [details]
Patch
Comment 2 Andreas Kling 2012-03-21 12:19:24 PDT
Comment on attachment 133090 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133090&action=review

r=me buuut..

> Source/WebCore/page/FrameView.cpp:855
> +        tiledBacking->setIsInWindow(true);

Should be setIsInWindow(false).

> Source/WebCore/page/Page.h:423
> +        bool m_isOnscreen;

My gut says s/m_isOnscreen/m_isOnScreen/g. But my gut has been wrong before.

> Source/WebCore/platform/graphics/ca/mac/TileCache.mm:227
> +    if (m_isInWindow == isInWindow)
> +        return;

I assume there's more code coming to this function, otherwise this is pretty overkill.
Comment 3 Anders Carlsson 2012-03-21 12:24:57 PDT
Committed r111593: <http://trac.webkit.org/changeset/111593>