Bug 81820

Summary: Rename touchpad fling curve, add curve parameters to constructor.
Product: WebKit Reporter: W. James MacLean <wjmaclean>
Component: New BugsAssignee: W. James MacLean <wjmaclean>
Status: RESOLVED FIXED    
Severity: Normal CC: enne, gustavo, jamesr, nduca, pnormand, rjkroege, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

W. James MacLean
Reported 2012-03-21 12:07:37 PDT
Rename touchpad fling curve, add curve parameters to constructor.
Attachments
Patch (21.40 KB, patch)
2012-03-21 12:09 PDT, W. James MacLean 		no flags
DetailsFormatted DiffDiff
Patch (22.25 KB, patch)
2012-03-21 12:40 PDT, W. James MacLean 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
W. James MacLean
Comment 1 2012-03-21 12:09:19 PDT
Created attachment 133089 [details] Patch
Philippe Normand
Comment 2 2012-03-21 12:17:39 PDT
Comment on attachment 133089 [details] Patch Attachment 133089 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12035638
W. James MacLean
Comment 3 2012-03-21 12:40:31 PDT
Created attachment 133098 [details] Patch
W. James MacLean
Comment 4 2012-03-21 12:40:56 PDT
Patch to update GTK make files.
Adrienne Walker
Comment 5 2012-03-21 14:07:49 PDT
It's really hard to read a diff when you both rename a file and change the implementation. I realize you're trying to move quickly here, but that's not helping.
W. James MacLean
Comment 6 2012-03-21 14:26:55 PDT
(In reply to comment #5) > It's really hard to read a diff when you both rename a file and change the implementation. I realize you're trying to move quickly here, but that's not helping. Sorry about that ... I hadn't quite realized how the diffs would turn out until after I uploaded the patch (git shows things more sensibly ...). Should I re-do them separately?
Adrienne Walker
Comment 7 2012-03-21 14:36:35 PDT
Comment on attachment 133098 [details] Patch No, don't bother. I've looked at it enough now that I see what's going on. Along with renaming a file, it just looks like you're removing a static (yay) and moving it to be a member variable that you can also now set from the constructor. Seems totally reasonable.
W. James MacLean
Comment 8 2012-03-22 05:59:24 PDT
(In reply to comment #7) > (From update of attachment 133098 [details]) > No, don't bother. I've looked at it enough now that I see what's going on. Along with renaming a file, it just looks like you're removing a static (yay) and moving it to be a member variable that you can also now set from the constructor. Seems totally reasonable. Thanks - I'll make sure not do combine a rename op with anything else in future :-)
WebKit Review Bot
Comment 9 2012-03-22 07:03:24 PDT
Comment on attachment 133098 [details] Patch Clearing flags on attachment: 133098 Committed r111686: <http://trac.webkit.org/changeset/111686>
WebKit Review Bot
Comment 10 2012-03-22 07:03:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.