Summary: | garden-o-matic should special case reftests | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ojan Vafai <ojan> | ||||||
Component: | Tools / Tests | Assignee: | Ojan Vafai <ojan> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, dglazkov | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 69227 | ||||||||
Attachments: |
|
Description
Ojan Vafai
2012-03-21 11:45:40 PDT
I don't plan to implement this feature any time soon, but other folks should feel free to. Created attachment 133886 [details]
Patch
Comment on attachment 133886 [details]
Patch
Whoops. Forgot to add test.
Created attachment 133890 [details]
Patch
Comment on attachment 133890 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133890&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:177 > + for (var builder in results) { We've been using forEach rather than loops. > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:203 > + $(header).append('<div class="non-action-button">Reftest cannot be rebaselined</div>'); What is the gardener supposed to do in this case? Can we provide some help text? (In reply to comment #5) > (From update of attachment 133890 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=133890&action=review > > > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:203 > > + $(header).append('<div class="non-action-button">Reftest cannot be rebaselined</div>'); > > What is the gardener supposed to do in this case? Can we provide some help text? I'm not really sure. Don't have enough experience with reftests to understand what the common pitfalls/solutions are. Open to suggestions. > I'm not really sure. Don't have enough experience with reftests to understand what the common pitfalls/solutions are. Open to suggestions.
Maybe we should say that? We could encourage folks to who run into these situations to email the gardening lists with thoughts about what we should do in these cases.
Committed r112149: <http://trac.webkit.org/changeset/112149> |