Bug 81804

Summary: Web Inspector: HeapProfiler: Heap snapshot worker has to report the errors to the front-end
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Ilya Tikhonovsky <loislo>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 78411    
Attachments:
Description Flags
Patch
none
Patch yurys: review+

Ilya Tikhonovsky
Reported 2012-03-21 11:10:18 PDT
%subj%
Attachments
Patch (5.87 KB, patch)
2012-03-21 11:13 PDT, Ilya Tikhonovsky 		no flags
DetailsFormatted DiffDiff
Patch (6.16 KB, patch)
2012-03-22 07:12 PDT, Ilya Tikhonovsky 		yurys: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2012-03-21 11:13:14 PDT
Created attachment 133079 [details] Patch
Timothy Hatcher
Comment 2 2012-03-21 13:00:16 PDT
Comment on attachment 133079 [details] Patch Please revise the ChangeLog and provide information on what changed and why (overall summary and per function).
Ilya Tikhonovsky
Comment 3 2012-03-22 07:12:36 PDT
Created attachment 133252 [details] Patch
Yury Semikhatsky
Comment 4 2012-03-22 07:59:19 PDT
Comment on attachment 133252 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133252&action=review > Source/WebCore/inspector/front-end/HeapSnapshotProxy.js:193 > + WebInspector.log(WebInspector.UIString("An error happend when a call for method '%s' was requested", event.data.errorMethodName)); happend -> happened > Source/WebCore/inspector/front-end/HeapSnapshotWorkerDispatcher.js:87 > + response.errorMethodName = data.methodName; I think method name can be derived from the callId on the requester's side.
Ilya Tikhonovsky
Comment 5 2012-03-22 08:05:07 PDT
Committed r111697: <http://trac.webkit.org/changeset/111697>
Note You need to log in before you can comment on or make changes to this bug.