Bug 81804 - Web Inspector: HeapProfiler: Heap snapshot worker has to report the errors to the front-end
Summary: Web Inspector: HeapProfiler: Heap snapshot worker has to report the errors to...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks: 78411
  Show dependency treegraph
 
Reported: 2012-03-21 11:10 PDT by Ilya Tikhonovsky
Modified: 2012-03-22 08:05 PDT (History)
10 users (show)

See Also:


Attachments
Patch (5.87 KB, patch)
2012-03-21 11:13 PDT, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff
Patch (6.16 KB, patch)
2012-03-22 07:12 PDT, Ilya Tikhonovsky
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2012-03-21 11:10:18 PDT
%subj%
Comment 1 Ilya Tikhonovsky 2012-03-21 11:13:14 PDT
Created attachment 133079 [details]
Patch
Comment 2 Timothy Hatcher 2012-03-21 13:00:16 PDT
Comment on attachment 133079 [details]
Patch

Please revise the ChangeLog and provide information on what changed and why (overall summary and per function).
Comment 3 Ilya Tikhonovsky 2012-03-22 07:12:36 PDT
Created attachment 133252 [details]
Patch
Comment 4 Yury Semikhatsky 2012-03-22 07:59:19 PDT
Comment on attachment 133252 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133252&action=review

> Source/WebCore/inspector/front-end/HeapSnapshotProxy.js:193
> +                WebInspector.log(WebInspector.UIString("An error happend when a call for method '%s' was requested", event.data.errorMethodName));

happend -> happened

> Source/WebCore/inspector/front-end/HeapSnapshotWorkerDispatcher.js:87
> +                response.errorMethodName = data.methodName;

I think method name can be derived from the callId on the requester's side.
Comment 5 Ilya Tikhonovsky 2012-03-22 08:05:07 PDT
Committed r111697: <http://trac.webkit.org/changeset/111697>