Bug 81782

Summary: Web Inspector: event listener section doesn't show all event listeners of the element ancestors
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch pfeldman: review+

Description Yury Semikhatsky 2012-03-21 07:40:20 PDT 
If selected node doesn't have any listener then the section will be empty. Currently ancestors event listeners are filtered by event listener names of the selected node.
Comment 1 Yury Semikhatsky 2012-03-21 07:48:53 PDT 
Created attachment 133039 [details]
Patch
Comment 2 Pavel Feldman 2012-03-21 08:17:52 PDT 
Comment on attachment 133039 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133039&action=review

> Source/WebCore/inspector/InspectorDOMAgent.cpp:726
> +void InspectorDOMAgent::getEventListenersForNode(ErrorString* error, int nodeId, RefPtr<InspectorArray>& listenersArray)

Please rebaseline

> Source/WebCore/inspector/InspectorDOMAgent.cpp:732
> +        *error = "No such node";

Please use assertNode
Comment 3 Yury Semikhatsky 2012-03-21 08:58:10 PDT 
Created attachment 133052 [details]
Patch
Comment 4 Yury Semikhatsky 2012-03-21 08:59:47 PDT 
(In reply to comment #2)
> (From update of attachment 133039 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=133039&action=review
> 
> > Source/WebCore/inspector/InspectorDOMAgent.cpp:726
> > +void InspectorDOMAgent::getEventListenersForNode(ErrorString* error, int nodeId, RefPtr<InspectorArray>& listenersArray)
> 
> Please rebaseline
> 
Done.

> > Source/WebCore/inspector/InspectorDOMAgent.cpp:732
> > +        *error = "No such node";
> 
> Please use assertNode
Done.
Comment 5 Yury Semikhatsky 2012-03-21 09:10:02 PDT 
Committed r111549: <http://trac.webkit.org/changeset/111549>