Bug 81782 – Web Inspector: event listener section doesn't show all event listeners of the element ancestors

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Yury Semikhatsky]

If selected node doesn't have any listener then the section will be empty. Currently ancestors event listeners are filtered by event listener names of the selected node.

[Yury Semikhatsky]

Created attachment 133039 [details]
Patch

[Pavel Feldman]

Comment on attachment 133039 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133039&action=review

> Source/WebCore/inspector/InspectorDOMAgent.cpp:726
> +void InspectorDOMAgent::getEventListenersForNode(ErrorString* error, int nodeId, RefPtr<InspectorArray>& listenersArray)

Please rebaseline

> Source/WebCore/inspector/InspectorDOMAgent.cpp:732
> +        *error = "No such node";

Please use assertNode

[Yury Semikhatsky]

Created attachment 133052 [details]
Patch

[Yury Semikhatsky]

(In reply to comment #2)
> (From update of attachment 133039 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=133039&action=review
> 
> > Source/WebCore/inspector/InspectorDOMAgent.cpp:726
> > +void InspectorDOMAgent::getEventListenersForNode(ErrorString* error, int nodeId, RefPtr<InspectorArray>& listenersArray)
> 
> Please rebaseline
> 
Done.

> > Source/WebCore/inspector/InspectorDOMAgent.cpp:732
> > +        *error = "No such node";
> 
> Please use assertNode
Done.

[Yury Semikhatsky]

Committed r111549: <http://trac.webkit.org/changeset/111549>