Bug 81782 - Web Inspector: event listener section doesn't show all event listeners of the element ancestors
Summary: Web Inspector: event listener section doesn't show all event listeners of the...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-21 07:40 PDT by Yury Semikhatsky
Modified: 2012-03-21 09:10 PDT (History)
10 users (show)

See Also:

Attachments
Patch (16.40 KB, patch)
2012-03-21 07:48 PDT, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
Patch (16.90 KB, patch)
2012-03-21 08:58 PDT, Yury Semikhatsky 		pfeldman: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2012-03-21 07:40:20 PDT 
If selected node doesn't have any listener then the section will be empty. Currently ancestors event listeners are filtered by event listener names of the selected node.
Comment 1 Yury Semikhatsky 2012-03-21 07:48:53 PDT 
Created attachment 133039 [details]
Patch
Comment 2 Pavel Feldman 2012-03-21 08:17:52 PDT 
Comment on attachment 133039 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133039&action=review

> Source/WebCore/inspector/InspectorDOMAgent.cpp:726
> +void InspectorDOMAgent::getEventListenersForNode(ErrorString* error, int nodeId, RefPtr<InspectorArray>& listenersArray)

Please rebaseline

> Source/WebCore/inspector/InspectorDOMAgent.cpp:732
> +        *error = "No such node";

Please use assertNode
Comment 3 Yury Semikhatsky 2012-03-21 08:58:10 PDT 
Created attachment 133052 [details]
Patch
Comment 4 Yury Semikhatsky 2012-03-21 08:59:47 PDT 
(In reply to comment #2)
> (From update of attachment 133039 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=133039&action=review
> 
> > Source/WebCore/inspector/InspectorDOMAgent.cpp:726
> > +void InspectorDOMAgent::getEventListenersForNode(ErrorString* error, int nodeId, RefPtr<InspectorArray>& listenersArray)
> 
> Please rebaseline
> 
Done.

> > Source/WebCore/inspector/InspectorDOMAgent.cpp:732
> > +        *error = "No such node";
> 
> Please use assertNode
Done.
Comment 5 Yury Semikhatsky 2012-03-21 09:10:02 PDT 
Committed r111549: <http://trac.webkit.org/changeset/111549>