Bug 81776

Summary: Web Inspector: HeapProfiler: DOM node id can overflow Int32.
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Ilya Tikhonovsky <loislo>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 78411    
Attachments:
Description Flags
Patch pfeldman: review+

Description Ilya Tikhonovsky 2012-03-21 06:45:28 PDT
Patch to follow.
Comment 1 Ilya Tikhonovsky 2012-03-21 07:07:49 PDT
Created attachment 133037 [details]
Patch
Comment 2 Pavel Feldman 2012-03-21 07:18:02 PDT
Comment on attachment 133037 [details]
Patch

This seems like a temporary measure. Is there a long term plan for even greater values?
Comment 3 Ilya Tikhonovsky 2012-03-21 07:22:07 PDT
Committed r111540: <http://trac.webkit.org/changeset/111540>
Comment 4 Ilya Tikhonovsky 2012-03-21 07:33:57 PDT
(In reply to comment #2)
> (From update of attachment 133037 [details])
> This seems like a temporary measure. Is there a long term plan for even greater values?

The node id has uint type at the backend. Thus it can't overflow uint by design.