Bug 81771

Summary: [Qt] WebGraphicsLayer: Untie the layer updates and tile updates.
Product: WebKit Reporter: Jocelyn Turcotte <jturcotte>
Component: New BugsAssignee: Jocelyn Turcotte <jturcotte>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, kenneth, menard, noam, ossy, webkit.review.bot, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 70236    
Attachments:
Description Flags
Patch
none
Patch noam: review+

Description Jocelyn Turcotte 2012-03-21 06:19:07 PDT
[Qt] WebGraphicsLayer: Untie the layer updates and tile updates.
Comment 1 Jocelyn Turcotte 2012-03-21 08:20:21 PDT
Created attachment 133046 [details]
Patch
Comment 2 Noam Rosenthal 2012-03-21 09:03:25 PDT
We should also avoid setting the m_modified flag if all we did is respond to an ancestor modifying the transform
Comment 3 WebKit Review Bot 2012-03-21 09:20:05 PDT
Comment on attachment 133046 [details]
Patch

Attachment 133046 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12070524

New failing tests:
fast/eventsource/eventsource-url-attribute.html
Comment 4 Jocelyn Turcotte 2012-03-21 09:36:13 PDT
(In reply to comment #3)
> (From update of attachment 133046 [details])
> Attachment 133046 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/12070524
> 
> New failing tests:
> fast/eventsource/eventsource-url-attribute.html

Unlikely related.
Comment 5 Jocelyn Turcotte 2012-03-21 10:25:41 PDT
Committed r111567: <http://trac.webkit.org/changeset/111567>
Comment 6 Csaba Osztrogonác 2012-03-26 05:15:55 PDT
Reopen, because it broke a Qt-WK2 API test:
FAIL!  : tst_QQuickWebView::showWebView() Received a fatal error.
   Loc: [Unknown file(0)]

Could you check what happened?
Comment 7 Jocelyn Turcotte 2012-03-26 07:34:54 PDT
Created attachment 133808 [details]
Patch
Comment 8 Jocelyn Turcotte 2012-03-26 07:55:22 PDT
Committed r112096: <http://trac.webkit.org/changeset/112096>