Bug 81766 – Web Inspector: get rid of isInEditMode, use isBeingEdited on particular element.

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Pavel Feldman]

We should check even target and its ancestors for being edited, not use some global property.

[Pavel Feldman]

Created attachment 133026 [details]
Patch

[Yury Semikhatsky]

Comment on attachment 133026 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133026&action=review

> Source/WebCore/ChangeLog:8
> +        We should check even target and its ancestors for being edited, not use some

even -> event

> Source/WebCore/inspector/front-end/UIUtils.js:192
> +    while (element && element.nodeType === Node.ELEMENT_NODE) {

Instead of element.nodeType === Node.ELEMENT_NODE you can just use element.parentElement below.

> Source/WebCore/inspector/front-end/utilities.js:381
> +    this.stopImmediatePropagation();

It was stopPropagation, are you sure this change won't break any listener?

[Pavel Feldman]

> even -> event

Done.

> 
> Instead of element.nodeType === Node.ELEMENT_NODE you can just use element.parentElement below.
>

Done.
 
> > Source/WebCore/inspector/front-end/utilities.js:381
> > +    this.stopImmediatePropagation();
> 
> It was stopPropagation, are you sure this change won't break any listener?

stopImmediatePropagation implies stopPropagation, so it should work.

[Pavel Feldman]

Committed r111551: <http://trac.webkit.org/changeset/111551>