Bug 81766

Summary: Web Inspector: get rid of isInEditMode, use isBeingEdited on particular element.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch yurys: review+

Description Pavel Feldman 2012-03-21 05:22:38 PDT
We should check even target and its ancestors for being edited, not use some global property.
Comment 1 Pavel Feldman 2012-03-21 05:59:29 PDT
Created attachment 133026 [details]
Patch
Comment 2 Yury Semikhatsky 2012-03-21 09:24:12 PDT
Comment on attachment 133026 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133026&action=review

> Source/WebCore/ChangeLog:8
> +        We should check even target and its ancestors for being edited, not use some

even -> event

> Source/WebCore/inspector/front-end/UIUtils.js:192
> +    while (element && element.nodeType === Node.ELEMENT_NODE) {

Instead of element.nodeType === Node.ELEMENT_NODE you can just use element.parentElement below.

> Source/WebCore/inspector/front-end/utilities.js:381
> +    this.stopImmediatePropagation();

It was stopPropagation, are you sure this change won't break any listener?
Comment 3 Pavel Feldman 2012-03-21 09:28:46 PDT
> even -> event

Done.

> 
> Instead of element.nodeType === Node.ELEMENT_NODE you can just use element.parentElement below.
>

Done.
 
> > Source/WebCore/inspector/front-end/utilities.js:381
> > +    this.stopImmediatePropagation();
> 
> It was stopPropagation, are you sure this change won't break any listener?

stopImmediatePropagation implies stopPropagation, so it should work.
Comment 4 Pavel Feldman 2012-03-21 09:33:28 PDT
Committed r111551: <http://trac.webkit.org/changeset/111551>