Bug 81754

Summary: Update LayoutUnit usage in FrameSelection
Product: WebKit Reporter: Levi Weintraub <leviw>
Component: Layout and RenderingAssignee: Levi Weintraub <leviw>
Status: RESOLVED FIXED    
Severity: Normal CC: eae, eric, jchaffraix, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60318    
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Levi Weintraub 2012-03-21 03:41:54 PDT
FrameSelection has several methods that operate on absolute coordinates, which we continue to express using integers.
Comment 1 Levi Weintraub 2012-03-21 04:12:10 PDT
Created attachment 133007 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-03-21 11:16:17 PDT
Comment on attachment 133007 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133007&action=review

> Source/WebCore/editing/FrameSelection.h:298
> +    IntRect m_absCaretBounds; // absolute bounding rect for the caret

This comment doesn't help much, but could be made to. :)
Comment 3 Levi Weintraub 2012-03-22 05:52:48 PDT
Created attachment 133236 [details]
Patch for landing
Comment 4 WebKit Review Bot 2012-03-22 07:14:29 PDT
Comment on attachment 133236 [details]
Patch for landing

Clearing flags on attachment: 133236

Committed r111689: <http://trac.webkit.org/changeset/111689>
Comment 5 WebKit Review Bot 2012-03-22 07:14:33 PDT
All reviewed patches have been landed.  Closing bug.