RESOLVED FIXED Bug 81754
Update LayoutUnit usage in FrameSelection 
https://bugs.webkit.org/show_bug.cgi?id=81754
Summary Update LayoutUnit usage in FrameSelection
Levi Weintraub
Reported 2012-03-21 03:41:54 PDT
FrameSelection has several methods that operate on absolute coordinates, which we continue to express using integers.
Attachments
Patch (7.57 KB, patch)
2012-03-21 04:12 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.72 KB, patch)
2012-03-22 05:52 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Levi Weintraub
Comment 1 2012-03-21 04:12:10 PDT
Created attachment 133007 [details] Patch
Eric Seidel (no email)
Comment 2 2012-03-21 11:16:17 PDT
Comment on attachment 133007 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133007&action=review > Source/WebCore/editing/FrameSelection.h:298 > + IntRect m_absCaretBounds; // absolute bounding rect for the caret This comment doesn't help much, but could be made to. :)
Levi Weintraub
Comment 3 2012-03-22 05:52:48 PDT
Created attachment 133236 [details] Patch for landing
WebKit Review Bot
Comment 4 2012-03-22 07:14:29 PDT
Comment on attachment 133236 [details] Patch for landing Clearing flags on attachment: 133236 Committed r111689: <http://trac.webkit.org/changeset/111689>
WebKit Review Bot
Comment 5 2012-03-22 07:14:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.