Bug 81754 - Update LayoutUnit usage in FrameSelection
Summary: Update LayoutUnit usage in FrameSelection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Levi Weintraub
URL:
Keywords:
Depends on:
Blocks: 60318
  Show dependency treegraph
 
Reported: 2012-03-21 03:41 PDT by Levi Weintraub
Modified: 2012-03-22 07:14 PDT (History)
4 users (show)

See Also:


Attachments
Patch (7.57 KB, patch)
2012-03-21 04:12 PDT, Levi Weintraub
no flags Details | Formatted Diff | Diff
Patch for landing (7.72 KB, patch)
2012-03-22 05:52 PDT, Levi Weintraub
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Levi Weintraub 2012-03-21 03:41:54 PDT
FrameSelection has several methods that operate on absolute coordinates, which we continue to express using integers.
Comment 1 Levi Weintraub 2012-03-21 04:12:10 PDT
Created attachment 133007 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-03-21 11:16:17 PDT
Comment on attachment 133007 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133007&action=review

> Source/WebCore/editing/FrameSelection.h:298
> +    IntRect m_absCaretBounds; // absolute bounding rect for the caret

This comment doesn't help much, but could be made to. :)
Comment 3 Levi Weintraub 2012-03-22 05:52:48 PDT
Created attachment 133236 [details]
Patch for landing
Comment 4 WebKit Review Bot 2012-03-22 07:14:29 PDT
Comment on attachment 133236 [details]
Patch for landing

Clearing flags on attachment: 133236

Committed r111689: <http://trac.webkit.org/changeset/111689>
Comment 5 WebKit Review Bot 2012-03-22 07:14:33 PDT
All reviewed patches have been landed.  Closing bug.